[PATCH] drm/bochs: Fix NULL dereference on atomic_disable helper

Gerd Hoffmann kraxel at redhat.com
Mon Mar 11 13:39:19 UTC 2019


  Hi,

> > IIRC the drm code checks for the atomic_enable callback presence to
> > figure whenever it should take the atomic or legacy code paths.
> 
> It should check for drm_driver->mode_config.funcs.atomic_commit for that,
> see drm_drv_uses_atomic_modeset(). Anything else should be a bug.
> 
> Or do you mean the fallback to the old crtc helper prepare/commit
> callbacks?

Probably the later.  There was some reason why I've left in the empty
bochs_crtc_atomic_enable() callback ...

cheers,
  Gerd



More information about the dri-devel mailing list