[PATCH] drm/udl: Bugfix in EDID reading routine

[Robert Tarasov]

Yes, you're right. Will prepare another patch which will use
drm_do_get_edid()

On Mon, Mar 11, 2019 at 4:33 AM Jani Nikula <jani.nikula at linux.intel.com>
wrote:

> On Fri, 08 Mar 2019, Robert Tarasov <tutankhamen at chromium.org> wrote:
> > Fixed bug with reading of last EDID extra block in drm/udl driver.
> > Previouse approach read all the blocks except the last one.
> >
> > Signed-off-by: Robert Tarasov <tutankhamen at chromium.org>
> > ---
> >  drivers/gpu/drm/udl/udl_connector.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/udl/udl_connector.c
> b/drivers/gpu/drm/udl/udl_connector.c
> > index c3dc1fd20cb4..68b221b9a01f 100644
> > --- a/drivers/gpu/drm/udl/udl_connector.c
> > +++ b/drivers/gpu/drm/udl/udl_connector.c
> > @@ -70,7 +70,7 @@ static bool udl_get_edid(struct udl_device *udl, u8
> **result_buff,
> >                       memcpy(buff_ptr, block_buff, EDID_LENGTH);
> >                       kfree(block_buff);
> >                       buff_ptr += EDID_LENGTH;
> > -                     for (i = 1; i < extensions; ++i) {
> > +                     for (i = 1; i <= extensions; ++i) {
> >                               if (udl_get_edid_block(udl, i, buff_ptr)) {
> >                                       buff_ptr += EDID_LENGTH;
> >                               } else {
>
> Ugh. Why doesn't udl use drm_do_get_edid()?
>
> BR,
> Jani.
>
>
> --
> Jani Nikula, Intel Open Source Graphics Center
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20190311/ec691d2f/attachment-0001.html>