[RFC PATCH] drm/panfrost: Add initial panfrost driver

[Rob Herring]

On Thu, Mar 14, 2019 at 4:01 AM Neil Armstrong <narmstrong at baylibre.com> wrote:
>
> On 08/03/2019 01:24, Rob Herring wrote:
> > From: "Marty E. Plummer" <hanetzer at startmail.com>
> >
> > This adds the initial driver for panfrost which supports Arm Mali
> > Midgard and Bifrost family of GPUs. Currently, only the T860 Midgard GPU
> > has been tested.
> >
> > Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> > Cc: Maxime Ripard <maxime.ripard at bootlin.com>
> > Cc: Sean Paul <sean at poorly.run>
> > Cc: David Airlie <airlied at linux.ie>
> > Cc: Daniel Vetter <daniel at ffwll.ch>
> > Cc: Alyssa Rosenzweig <alyssa at rosenzweig.io>
> > Cc: Lyude Paul <lyude at redhat.com>
> > Cc: Eric Anholt <eric at anholt.net>
> > Signed-off-by: Marty E. Plummer <hanetzer at startmail.com>
> > Signed-off-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>
> > Signed-off-by: Rob Herring <robh at kernel.org>
> > ---
> > Sending this out in the spirit of release early, release often. We're
> > close to parity compared to mesa + the vendor driver. There's a few
> > issues Tomeu is chasing.
> >
> > There's still some pieces of the h/w setup we've just hardcoded. Locking
> > in various places is probably missing. Error recovery is non-existent
> > (other than module unload/load). There's some work to add tracepoints
> > and perf counters that's not here yet. Bifrost GPUs are definitely not
> > supported yet other than identifying them. Primarily the MMU setup is
> > missing.

[...]

> > diff --git a/drivers/gpu/drm/panfrost/Kconfig b/drivers/gpu/drm/panfrost/Kconfig
> > new file mode 100644
> > index 000000000000..eb7283149354
> > --- /dev/null
> > +++ b/drivers/gpu/drm/panfrost/Kconfig
> > @@ -0,0 +1,14 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +
> > +config DRM_PANFROST
> > +     tristate "Panfrost (DRM support for ARM Mali Midgard/Bifrost GPUs)"
> > +     depends on DRM
> > +     depends on ARCH_ROCKCHIP
>
> Could you switch to
> +       depends on ARM || ARM64 || COMPILE_TEST
> instead of ARCH_ROCKHIP ?
>
> It will simply bringup on non-rockchip boards.

Yes, certainly.