[PATCH 2/2] drm/fb: avoid setting 0 depth.

Linus Walleij linus.walleij at linaro.org
Fri Mar 15 09:52:51 UTC 2019


On Fri, Mar 15, 2019 at 2:46 AM Dave Airlie <airlied at gmail.com> wrote:

> From: Dave Airlie <airlied at redhat.com>
>
> If the downscaling fails and we end up with a best_depth of 0,
> then ignore it.
>
> This actually works around a cascade of failure, but it the
> simplest fix for now.
>
> The scaling patch broke the udl driver, as the udl driver doesn't
> expose planes at all, so gets the two default 32-bit formats, but
> the udl driver then ask for 16bpp fbdev, and the scaling code falls
> over.
>
> This fixes the udl driver since the scaled depth support was added.
>
> Fixes: f4bd542bcaee (drm/fb-helper: Scale back depth to supported maximum)
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> Cc: Linus Walleij <linus.walleij at linaro.org>
> Signed-off-by: Dave Airlie <airlied at redhat.com>

Good catch! Sorry for not seeing this risk...
Reviewed-by: Linus Walleij <linus.walleij at linaro.org>

Yours,
Linus Walleij


More information about the dri-devel mailing list