[PATCH] android: libdrm_platform: add liblog shared dependency

[Mauro Rossi]

Hi,

On Mon, Mar 18, 2019 at 10:58 AM Robert Foss <robert.foss at collabora.com> wrote:
>
> Hey Mauro,
>
> On 3/18/19 9:38 AM, Mauro Rossi wrote:
> > Hi Robert,
> >
> > On Mon, Mar 18, 2019 at 9:21 AM Robert Foss <robert.foss at collabora.com> wrote:
> >>
> >> On a second note, this does not apply on libdrm/master due
> >> to:
> >>
> >> LOCAL_SHARED_LIBRARIES := \
> >>          libcutils
> >
> > Sorry, we have an additional Google patch, not present in libdrm/master
> > that adds libdrm_platform module, but it is for a specific Google issue. [1]
> >
> > However with libdrm module we have both liblog and libcutils shared dependencies
> >
> > [1] http://git.osdn.net/view?p=android-x86/external-libdrm.git;a=commit;h=8ccbfeab9fb2bddf4585339a0bcbea2f1e3ffa1e
>
> Do you know if [1] causes incompatibility issues with earlier android verions?
> If not I would suggest upstreaming it too.

I used those patches to build with nougat-x86 and there was no issue.

To be precise I did a double rookie mistake, because __android_log_vprint
not used in upstream libdrm and libdrm_platform not used either.

Now starting from my mistakes, let's see if there is anything useful
to libdrm project

In our builds Chih-Wei Huang said that libdrm_platform is not used,
meaning not added to packages list,
however with oreo-x86 the build error appeared and the liblog dependency.

 __android_log_vprint is used with __ANDROID__ braces
in a special patch [2] by Chih-Wei Huang which adds capability to print logs
in logcat

If it's not too invasive in libdrm, it could be useful.
Cheers
Mauro

[2] http://git.osdn.net/view?p=android-x86/external-libdrm.git;a=commitdiff;h=bcee43063ffd52a8677029c9ae6f4203563460f4;hp=81d7264033db4946a00003bf1ee82eb6c21260f9

>
> >
> > Mauro
> >
> >>
> >> My thinking is that libcutils probably can be replaced with liblog,
> >> but I'm not 100% sure.
> >>
> >>
> >> Rob.
> >>
> >> On 3/18/19 9:09 AM, Robert Foss wrote:
> >>> This is probably a good idea!
> >>>
> >>>
> >>> Reviewed-by: Robert Foss <robert.foss at collabora.com>
> >>>
> >>> On 3/17/19 9:54 PM, Mauro Rossi wrote:
> >>>> Hi,
> >>>> I used the option --subject-prefix="PATCH libdrm"
> >>>> but it did not go as expected.
> >>>>
> >>>> Anyway, the patch is for Android build of mesa/drm
> >>>> Mauro
> >>>>
> >>>> On Sun, Mar 17, 2019 at 9:50 PM Mauro Rossi <issor.oruam at gmail.com> wrote:
> >>>>>
> >>>>> Fixes the following building error:
> >>>>>
> >>>>> FAILED:
> >>>>> $(OUT)/obj/SHARED_LIBRARIES/libdrm_platform_intermediates/LINKED/libdrm_platform.so
> >>>>>
> >>>>> ...
> >>>>> external/libdrm/xf86drm.c:146: error: undefined reference to
> >>>>> '__android_log_vprint'
> >>>>> clang.real: error: linker command failed with exit code 1 (use -v to see
> >>>>> invocation)
> >>>>>
> >>>>> Signed-off-by: Mauro Rossi <issor.oruam at gmail.com>
> >>>>> ---
> >>>>>    Android.mk | 3 +++
> >>>>>    1 file changed, 3 insertions(+)
> >>>>>
> >>>>> diff --git a/Android.mk b/Android.mk
> >>>>> index f2c78bc1..f832b24e 100644
> >>>>> --- a/Android.mk
> >>>>> +++ b/Android.mk
> >>>>> @@ -61,6 +61,9 @@ LOCAL_EXPORT_C_INCLUDE_DIRS := \
> >>>>>           $(LOCAL_PATH) \
> >>>>>           $(LOCAL_PATH)/include/drm
> >>>>>
> >>>>> +LOCAL_SHARED_LIBRARIES := \
> >>>>> +       liblog
> >>>>> +
> >>>>>    LOCAL_C_INCLUDES := \
> >>>>>           $(LOCAL_PATH)/include/drm
> >>>>>
> >>>>> --
> >>>>> 2.19.1
> >>>>>
> >>>> _______________________________________________
> >>>> dri-devel mailing list
> >>>> dri-devel at lists.freedesktop.org
> >>>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> >>>>
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> >