[PATCH 1/2] dma-fence: Propagate errors to dma-fence-array container

kbuild test robot lkp at intel.com
Mon Mar 25 11:08:48 UTC 2019


Hi Chris,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.1-rc2 next-20190325]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Chris-Wilson/dma-fence-Propagate-errors-to-dma-fence-array-container/20190325-074009
config: sh-allyesconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=sh 

All errors (new ones prefixed by >>):

   drivers/dma-buf/dma-fence-array.c: In function 'dma_fence_array_cb_func':
>> drivers/dma-buf/dma-fence-array.c:50:3: error: implicit declaration of function 'cmpxchg_local'; did you mean 'cmpxchg_relaxed'? [-Werror=implicit-function-declaration]
      cmpxchg_local(&array->base.error, 0, f->error);
      ^~~~~~~~~~~~~
      cmpxchg_relaxed
   cc1: some warnings being treated as errors

vim +50 drivers/dma-buf/dma-fence-array.c

    41	
    42	static void dma_fence_array_cb_func(struct dma_fence *f,
    43					    struct dma_fence_cb *cb)
    44	{
    45		struct dma_fence_array_cb *array_cb =
    46			container_of(cb, struct dma_fence_array_cb, cb);
    47		struct dma_fence_array *array = array_cb->array;
    48	
    49		if (atomic_read(&array->num_pending) > 0)
  > 50			cmpxchg_local(&array->base.error, 0, f->error);
    51	
    52		if (atomic_dec_and_test(&array->num_pending))
    53			irq_work_queue(&array->work);
    54		else
    55			dma_fence_put(&array->base);
    56	}
    57	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 51417 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20190325/e2deac5f/attachment-0001.gz>


More information about the dri-devel mailing list