[PATCH] omapdrm: hdmi4_cec: Fix CEC clock handling for PM
Tony Lindgren
tony at atomide.com
Tue Mar 26 14:36:22 UTC 2019
* Hans Verkuil <hverkuil at xs4all.nl> [190326 06:36]:
> On 3/26/19 12:47 AM, Tony Lindgren wrote:
> > @@ -169,12 +169,19 @@ static int hdmi_cec_adap_enable(struct cec_adapter *adap, bool enable)
> > struct hdmi_core_data *core = cec_get_drvdata(adap);
> > int temp, err;
> >
> > - if (!enable) {
> > + if (enable) {
> > + /*
> > + * Initialize CEC clock divider: CEC needs 2MHz clock hence
> > + * set the divider to 24 to get 48/24=2MHz clock
> > + */
> > + REG_FLD_MOD(core->wp->base, HDMI_WP_CLK, 0x18, 5, 0);
>
> Please move this to after the 'if'. That's where all the other
> 'enable' code is.
Oops yeah that's better, will post v2 shortly.
Regards,
Tony
More information about the dri-devel
mailing list