[PATCH] [v7, 2/2] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

dbasehore . dbasehore at chromium.org
Wed Mar 27 03:11:51 UTC 2019


On Tue, Mar 26, 2019 at 12:09 AM Jerry Han <jerry.han.hq at gmail.com> wrote:
>
> Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI
> panel.
>
> V7:
> - Add the information of the reviewer
> - Remove unnecessary delays, The udelay_range code gracefully returns
>     without hitting the scheduler on a delay of 0. (Derek)
> - Merge the same data structures, like display_mode and off_cmds (Derek)
> - Optimize the processing of results returned by
>     devm_gpiod_get_optional (Derek)

Looks good to me overall. There's still some duplication on values
like number of lanes, but that's not a blocking concern for me.

>
> V6:
> - Add the information of the reviewer (Sam)
> - Delete unnecessary header files #include <linux/fb.h> (Sam)
> - The config DRM_PANEL_BOE_HIMAX8279D appears twice. Drop one of them (Sam)
> - ADD static, set_gpios function is not used outside this module (Sam)
>
> V5:
> - Added changelog
>
> V4:
> - Frefix all function maes with boe_ (Sam)
> - Fsed "enable_gpio" replace "reset_gpio", Make it look clearer (Sam)
> - Sort include lines alphabetically (Sam)
> - Fixed entries in the makefile must be sorted alphabetically (Sam)
> - Add send_mipi_cmds function to avoid duplicating the code (Sam)
> - Add the necessary delay(reset_delay_t5) between reset and sending
>     the initialization command (Rock wang)
>
> V3:
> - Remove unnecessary delays in sending initialization commands (Jitao Shi)
>
> V2:
> - Use SPDX identifier (Sam)
> - Use necessary header files replace drmP.h (Sam)
> - Delete unnecessary header files #include <linux/err.h> (Sam)
> - Specifies a GPIOs array to control the reset timing,
>     instead of reading "dsi-reset-sequence" data from DTS (Sam)
> - Delete backlight_disable() function when already disabled (Sam)
> - Use devm_of_find_backlight() replace of_find_backlight_by_node() (Sam)
> - Move the necessary data in the DTS to the current file,
>     like porch, display_mode and Init code etc. (Sam)
> - Add compatible device "boe,himax8279d10p" (Sam)
>
> Signed-off-by: Jerry Han <hanxu5 at huaqin.corp-partner.google.com>
> Reviewed-by: Sam Ravnborg <sam at ravnborg.org>
> Reviewed-by: Derek Basehore <dbasehore at chromium.org>
> Cc: Jitao Shi <jitao.shi at mediatek.com>
> Cc: Rock wang <rock_wang at himax.com.cn>
> ---
>  MAINTAINERS                                  |    6 +
>  drivers/gpu/drm/panel/Kconfig                |   11 +
>  drivers/gpu/drm/panel/Makefile               |    1 +
>  drivers/gpu/drm/panel/panel-boe-himax8279d.c | 1050 ++++++++++++++++++
>  4 files changed, 1068 insertions(+)
>  create mode 100644 drivers/gpu/drm/panel/panel-boe-himax8279d.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f8e63bcc4c1c..267468ca72bb 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4816,6 +4816,12 @@ T:       git git://anongit.freedesktop.org/drm/drm-misc
>  S:     Maintained
>  F:     drivers/gpu/drm/bochs/
>
> +DRM DRIVER FOR BOE HIMAX8279D PANELS
> +M:     Jerry Han <hanxu5 at huaqin.corp-partner.google.com>
> +S:     Maintained
> +F:     drivers/gpu/drm/panel/panel-boe-himax8279d.c
> +F:     Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt
> +
>  DRM DRIVER FOR FARADAY TVE200 TV ENCODER
>  M:     Linus Walleij <linus.walleij at linaro.org>
>  T:     git git://anongit.freedesktop.org/drm/drm-misc
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index f53f817356db..fe2f87cc6627 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -17,6 +17,17 @@ config DRM_PANEL_ARM_VERSATILE
>           reference designs. The panel is detected using special registers
>           in the Versatile family syscon registers.
>
> +config DRM_PANEL_BOE_HIMAX8279D
> +       tristate "Boe Himax8279d panel"
> +       depends on OF
> +       depends on DRM_MIPI_DSI
> +       depends on BACKLIGHT_CLASS_DEVICE
> +       help
> +         Say Y here if you want to enable support for Boe Himax8279d
> +         TFT-LCD modules. The panel has a 1200x1920 resolution and uses
> +         24 bit RGB per pixel. It provides a MIPI DSI interface to
> +         the host and has a built-in LED backlight.
> +
>  config DRM_PANEL_LVDS
>         tristate "Generic LVDS panel driver"
>         depends on OF
> diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile
> index 7834947a53b0..c4814b6f069e 100644
> --- a/drivers/gpu/drm/panel/Makefile
> +++ b/drivers/gpu/drm/panel/Makefile
> @@ -1,5 +1,6 @@
>  # SPDX-License-Identifier: GPL-2.0
>  obj-$(CONFIG_DRM_PANEL_ARM_VERSATILE) += panel-arm-versatile.o
> +obj-$(CONFIG_DRM_PANEL_BOE_HIMAX8279D) += panel-boe-himax8279d.o
>  obj-$(CONFIG_DRM_PANEL_LVDS) += panel-lvds.o
>  obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o
>  obj-$(CONFIG_DRM_PANEL_ILITEK_IL9322) += panel-ilitek-ili9322.o
> diff --git a/drivers/gpu/drm/panel/panel-boe-himax8279d.c b/drivers/gpu/drm/panel/panel-boe-himax8279d.c
> new file mode 100644
> index 000000000000..ff5a89e38fd7
> --- /dev/null
> +++ b/drivers/gpu/drm/panel/panel-boe-himax8279d.c
> @@ -0,0 +1,1050 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2019, Huaqin Telecom Technology Co., Ltd
> + *
> + * Author: Jerry Han <hanxu5 at huaqin.corp-partner.google.com>
> + *
> + */
> +
> +#include <linux/backlight.h>
> +#include <linux/delay.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/of_device.h>
> +
> +#include <linux/gpio/consumer.h>
> +#include <linux/regulator/consumer.h>
> +
> +#include <drm/drm_device.h>
> +#include <drm/drm_mipi_dsi.h>
> +#include <drm/drm_modes.h>
> +#include <drm/drm_panel.h>
> +#include <drm/drm_print.h>
> +
> +#include <video/mipi_display.h>
> +
> +struct panel_cmd {
> +       size_t len;
> +       const char *data;
> +};
> +
> +#define _INIT_CMD(...) { \
> +       .len = sizeof((char[]){__VA_ARGS__}), \
> +       .data = (char[]){__VA_ARGS__} }
> +
> +struct panel_desc {
> +       const struct drm_display_mode *display_mode;
> +       unsigned int bpc;
> +       unsigned int width_mm;
> +       unsigned int height_mm;
> +
> +       unsigned int delay_t1;
> +       unsigned int reset_delay_t2;
> +       unsigned int reset_delay_t3;
> +       unsigned int reset_delay_t4;
> +       unsigned int reset_delay_t5;
> +
> +       unsigned long mode_flags;
> +       enum mipi_dsi_pixel_format format;
> +       unsigned int lanes;
> +       const struct panel_cmd *on_cmds;
> +       const struct panel_cmd *off_cmds;
> +};
> +
> +struct panel_info {
> +       struct drm_panel base;
> +       struct mipi_dsi_device *link;
> +       const struct panel_desc *desc;
> +
> +       struct backlight_device *backlight;
> +       struct gpio_desc *enable_gpio;
> +       struct gpio_desc *pp33_gpio;
> +       struct gpio_desc *pp18_gpio;
> +
> +       bool prepared;
> +       bool enabled;
> +};
> +
> +static inline struct panel_info *to_panel_info(struct drm_panel *panel)
> +{
> +       return container_of(panel, struct panel_info, base);
> +}
> +
> +static void set_gpios(struct panel_info *pinfo, int enable)
> +{
> +       gpiod_set_value(pinfo->enable_gpio, enable);
> +       gpiod_set_value(pinfo->pp33_gpio, enable);
> +       gpiod_set_value(pinfo->pp18_gpio, enable);
> +}
> +
> +static int send_mipi_cmds(struct drm_panel *panel, const struct panel_cmd *cmds)
> +{
> +       struct panel_info *pinfo = to_panel_info(panel);
> +       unsigned int i = 0;
> +       int err;
> +
> +       if (!cmds)
> +               return -EFAULT;
> +
> +       for (i = 0; cmds[i].len != 0; i++) {
> +               const struct panel_cmd *cmd = &cmds[i];
> +
> +               if (cmd->len == 2)
> +                       err = mipi_dsi_dcs_write(pinfo->link,
> +                                                   cmd->data[1], NULL, 0);
> +               else
> +                       err = mipi_dsi_dcs_write(pinfo->link,
> +                                                   cmd->data[1], cmd->data + 2,
> +                                                   cmd->len - 2);
> +
> +               if (err < 0)
> +                       return err;
> +
> +               usleep_range((cmd->data[0]) * 1000,
> +                           (1 + cmd->data[0]) * 1000);
> +       }
> +
> +       return 0;
> +}
> +
> +static int boe_panel_disable(struct drm_panel *panel)
> +{
> +       struct panel_info *pinfo = to_panel_info(panel);
> +
> +       backlight_disable(pinfo->backlight);
> +
> +       pinfo->enabled = false;
> +
> +       return 0;
> +}
> +
> +static int boe_panel_unprepare(struct drm_panel *panel)
> +{
> +       struct panel_info *pinfo = to_panel_info(panel);
> +       int err;
> +
> +       if (!pinfo->prepared)
> +               return 0;
> +
> +       /* send off code */
> +       err = send_mipi_cmds(panel, pinfo->desc->off_cmds);
> +       if (err < 0) {
> +               DRM_DEV_ERROR(panel->dev,
> +                               "failed to send DCS Off Code: %d\n", err);
> +               goto poweroff;
> +       }
> +
> +       set_gpios(pinfo, 0);
> +
> +       pinfo->prepared = false;
> +
> +       return 0;
> +
> +poweroff:
> +       set_gpios(pinfo, 0);
> +       return err;
> +}
> +
> +static int boe_panel_prepare(struct drm_panel *panel)
> +{
> +       struct panel_info *pinfo = to_panel_info(panel);
> +       const struct panel_desc *desc = pinfo->desc;
> +       int err;
> +
> +       if (pinfo->prepared)
> +               return 0;
> +
> +       gpiod_set_value(pinfo->pp18_gpio, 1);
> +       /* T1 (> 5ms) */
> +       usleep_range(desc->delay_t1, 1000 + desc->delay_t1);
> +       gpiod_set_value(pinfo->pp33_gpio, 1);
> +
> +       /* reset sequence */
> +       usleep_range(desc->reset_delay_t2, 1000 + desc->reset_delay_t2);
> +
> +       gpiod_set_value(pinfo->enable_gpio, 1);
> +       usleep_range(desc->reset_delay_t3, 1000 + desc->reset_delay_t3);
> +       gpiod_set_value(pinfo->enable_gpio, 0);
> +
> +       usleep_range(desc->reset_delay_t4, 1000 + desc->reset_delay_t4);
> +       gpiod_set_value(pinfo->enable_gpio, 1);
> +
> +       usleep_range(desc->reset_delay_t5, 1000 + desc->reset_delay_t5);
> +
> +       /* send init code */
> +       err = send_mipi_cmds(panel, pinfo->desc->on_cmds);
> +       if (err < 0) {
> +               DRM_DEV_ERROR(panel->dev,
> +                               "failed to send DCS Init Code: %d\n", err);
> +               goto poweroff;
> +       }
> +
> +       pinfo->prepared = true;
> +
> +       return 0;
> +
> +poweroff:
> +       set_gpios(pinfo, 0);
> +       return err;
> +}
> +
> +static int boe_panel_enable(struct drm_panel *panel)
> +{
> +       struct panel_info *pinfo = to_panel_info(panel);
> +       int ret;
> +
> +       if (pinfo->enabled)
> +               return 0;
> +
> +       ret = backlight_enable(pinfo->backlight);
> +       if (ret) {
> +               DRM_DEV_ERROR(panel->drm->dev,
> +                               "Failed to enable backlight %d\n", ret);
> +               return ret;
> +       }
> +
> +       pinfo->enabled = true;
> +
> +       return 0;
> +}
> +
> +static int boe_panel_get_modes(struct drm_panel *panel)
> +{
> +       struct panel_info *pinfo = to_panel_info(panel);
> +       const struct drm_display_mode *m = pinfo->desc->display_mode;
> +       struct drm_display_mode *mode;
> +
> +       mode = drm_mode_duplicate(panel->drm, m);
> +       if (!mode) {
> +               DRM_DEV_ERROR(panel->drm->dev, "failed to add mode %ux%u@%u\n",
> +                               m->hdisplay, m->vdisplay, m->vrefresh);
> +               return -ENOMEM;
> +       }
> +
> +       drm_mode_set_name(mode);
> +
> +       drm_mode_probed_add(panel->connector, mode);
> +
> +       panel->connector->display_info.width_mm = pinfo->desc->width_mm;
> +       panel->connector->display_info.height_mm = pinfo->desc->height_mm;
> +       panel->connector->display_info.bpc = pinfo->desc->bpc;
> +
> +       return 1;
> +}
> +
> +static const struct drm_panel_funcs panel_funcs = {
> +       .disable = boe_panel_disable,
> +       .unprepare = boe_panel_unprepare,
> +       .prepare = boe_panel_prepare,
> +       .enable = boe_panel_enable,
> +       .get_modes = boe_panel_get_modes,
> +};
> +
> +static const struct drm_display_mode default_display_mode = {
> +       .clock = 159420,
> +       .hdisplay = 1200,
> +       .hsync_start = 1200 + 80,
> +       .hsync_end = 1200 + 80 + 60,
> +       .htotal = 1200 + 80 + 60 + 24,
> +       .vdisplay = 1920,
> +       .vsync_start = 1920 + 10,
> +       .vsync_end = 1920 + 10 + 14,
> +       .vtotal = 1920 + 10 + 14 + 4,
> +       .vrefresh = 60,
> +};
> +
> +static const struct panel_cmd default_off_cmds[] = {
> +       _INIT_CMD(0x00, 0x28),
> +       _INIT_CMD(0x01, 0x10),
> +
> +       {},
> +};
> +
> +/* 8 inch */
> +static const struct panel_cmd boe_himax8279d8p_on_cmds[] = {
> +       _INIT_CMD(0x22, 0x10),
> +       _INIT_CMD(0x00, 0xB0, 0x05),
> +       _INIT_CMD(0x00, 0xB1, 0xE5),
> +       _INIT_CMD(0x00, 0xB3, 0x52),
> +       _INIT_CMD(0x00, 0xB0, 0x00),
> +       _INIT_CMD(0x00, 0xB3, 0x88),
> +       _INIT_CMD(0x00, 0xB0, 0x04),
> +       _INIT_CMD(0x00, 0xB8, 0x00),
> +       _INIT_CMD(0x00, 0xB0, 0x00),
> +       _INIT_CMD(0x00, 0xB2, 0x50),
> +       _INIT_CMD(0x00, 0xB6, 0x03),
> +       _INIT_CMD(0x00, 0xBA, 0x8B),
> +       _INIT_CMD(0x00, 0xBF, 0x15),
> +       _INIT_CMD(0x00, 0xC0, 0x0F),
> +       _INIT_CMD(0x00, 0xC2, 0x0C),
> +       _INIT_CMD(0x00, 0xC3, 0x02),
> +       _INIT_CMD(0x00, 0xC4, 0x0C),
> +       _INIT_CMD(0x00, 0xC5, 0x02),
> +       _INIT_CMD(0x00, 0xB0, 0x01),
> +       _INIT_CMD(0x00, 0xE0, 0x26),
> +       _INIT_CMD(0x00, 0xE1, 0x26),
> +       _INIT_CMD(0x00, 0xDC, 0x00),
> +       _INIT_CMD(0x00, 0xDD, 0x00),
> +       _INIT_CMD(0x00, 0xCC, 0x26),
> +       _INIT_CMD(0x00, 0xCD, 0x26),
> +       _INIT_CMD(0x00, 0xC8, 0x00),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xD2, 0x04),
> +       _INIT_CMD(0x00, 0xD3, 0x04),
> +       _INIT_CMD(0x00, 0xE6, 0x03),
> +       _INIT_CMD(0x00, 0xE7, 0x03),
> +       _INIT_CMD(0x00, 0xC4, 0x08),
> +       _INIT_CMD(0x00, 0xC5, 0x08),
> +       _INIT_CMD(0x00, 0xD8, 0x07),
> +       _INIT_CMD(0x00, 0xD9, 0x07),
> +       _INIT_CMD(0x00, 0xC2, 0x06),
> +       _INIT_CMD(0x00, 0xC3, 0x06),
> +       _INIT_CMD(0x00, 0xD6, 0x05),
> +       _INIT_CMD(0x00, 0xD7, 0x05),
> +       _INIT_CMD(0x00, 0xC0, 0x0C),
> +       _INIT_CMD(0x00, 0xC1, 0x0C),
> +       _INIT_CMD(0x00, 0xD4, 0x0B),
> +       _INIT_CMD(0x00, 0xD5, 0x0B),
> +       _INIT_CMD(0x00, 0xCA, 0x0A),
> +       _INIT_CMD(0x00, 0xCB, 0x0A),
> +       _INIT_CMD(0x00, 0xDE, 0x09),
> +       _INIT_CMD(0x00, 0xDF, 0x09),
> +       _INIT_CMD(0x00, 0xC6, 0x26),
> +       _INIT_CMD(0x00, 0xC7, 0x26),
> +       _INIT_CMD(0x00, 0xCE, 0x00),
> +       _INIT_CMD(0x00, 0xCF, 0x00),
> +       _INIT_CMD(0x00, 0xDA, 0x26),
> +       _INIT_CMD(0x00, 0xDB, 0x26),
> +       _INIT_CMD(0x00, 0xE2, 0x00),
> +       _INIT_CMD(0x00, 0xE3, 0x00),
> +       _INIT_CMD(0x00, 0xB0, 0x02),
> +       _INIT_CMD(0x00, 0xC0, 0x00),
> +       _INIT_CMD(0x00, 0xC1, 0x07),
> +       _INIT_CMD(0x00, 0xC2, 0x0D),
> +       _INIT_CMD(0x00, 0xC3, 0x18),
> +       _INIT_CMD(0x00, 0xC4, 0x27),
> +       _INIT_CMD(0x00, 0xC5, 0x28),
> +       _INIT_CMD(0x00, 0xC6, 0x30),
> +       _INIT_CMD(0x00, 0xC7, 0x2E),
> +       _INIT_CMD(0x00, 0xC8, 0x2F),
> +       _INIT_CMD(0x00, 0xC9, 0x1A),
> +       _INIT_CMD(0x00, 0xCA, 0x20),
> +       _INIT_CMD(0x00, 0xCB, 0x29),
> +       _INIT_CMD(0x00, 0xCC, 0x26),
> +       _INIT_CMD(0x00, 0xCD, 0x32),
> +       _INIT_CMD(0x00, 0xCE, 0x33),
> +       _INIT_CMD(0x00, 0xCF, 0x31),
> +       _INIT_CMD(0x00, 0xD0, 0x06),
> +       _INIT_CMD(0x00, 0xD2, 0x00),
> +       _INIT_CMD(0x00, 0xD3, 0x07),
> +       _INIT_CMD(0x00, 0xD4, 0x12),
> +       _INIT_CMD(0x00, 0xD5, 0x26),
> +       _INIT_CMD(0x00, 0xD6, 0x3D),
> +       _INIT_CMD(0x00, 0xD7, 0x3F),
> +       _INIT_CMD(0x00, 0xD8, 0x3F),
> +       _INIT_CMD(0x00, 0xD9, 0x3F),
> +       _INIT_CMD(0x00, 0xDA, 0x3F),
> +       _INIT_CMD(0x00, 0xDB, 0x3F),
> +       _INIT_CMD(0x00, 0xDC, 0x3F),
> +       _INIT_CMD(0x00, 0xDD, 0x3F),
> +       _INIT_CMD(0x00, 0xDE, 0x3F),
> +       _INIT_CMD(0x00, 0xDF, 0x3A),
> +       _INIT_CMD(0x00, 0xE0, 0x37),
> +       _INIT_CMD(0x00, 0xE1, 0x35),
> +       _INIT_CMD(0x00, 0xE2, 0x07),
> +       _INIT_CMD(0x00, 0xB0, 0x03),
> +       _INIT_CMD(0x00, 0xC8, 0x0B),
> +       _INIT_CMD(0x00, 0xC9, 0x07),
> +       _INIT_CMD(0x00, 0xC3, 0x00),
> +       _INIT_CMD(0x00, 0xE7, 0x00),
> +       _INIT_CMD(0x00, 0xC5, 0x2A),
> +       _INIT_CMD(0x00, 0xDE, 0x2A),
> +       _INIT_CMD(0x00, 0xCA, 0x43),
> +       _INIT_CMD(0x00, 0xC9, 0x07),
> +       _INIT_CMD(0x00, 0xE4, 0xC0),
> +       _INIT_CMD(0x00, 0xE5, 0x0D),
> +       _INIT_CMD(0x00, 0xCB, 0x00),
> +       _INIT_CMD(0x00, 0xB0, 0x06),
> +       _INIT_CMD(0x00, 0xB8, 0xA5),
> +       _INIT_CMD(0x00, 0xC0, 0xA5),
> +       _INIT_CMD(0x00, 0xC7, 0x0F),
> +       _INIT_CMD(0x00, 0xD5, 0x32),
> +       _INIT_CMD(0x00, 0xB8, 0x00),
> +       _INIT_CMD(0x00, 0xC0, 0x00),
> +       _INIT_CMD(0x00, 0xBC, 0x00),
> +       _INIT_CMD(0x00, 0xB0, 0x07),
> +       _INIT_CMD(0x00, 0xB1, 0x00),
> +       _INIT_CMD(0x00, 0xB2, 0x09),
> +       _INIT_CMD(0x00, 0xB3, 0x19),
> +       _INIT_CMD(0x00, 0xB4, 0x2F),
> +       _INIT_CMD(0x00, 0xB5, 0x44),
> +       _INIT_CMD(0x00, 0xB6, 0x52),
> +       _INIT_CMD(0x00, 0xB7, 0x6A),
> +       _INIT_CMD(0x00, 0xB8, 0x8A),
> +       _INIT_CMD(0x00, 0xB9, 0xCA),
> +       _INIT_CMD(0x00, 0xBA, 0x0C),
> +       _INIT_CMD(0x05, 0xBB, 0x87),
> +       _INIT_CMD(0x00, 0xBC, 0x06),
> +       _INIT_CMD(0x00, 0xBD, 0x0A),
> +       _INIT_CMD(0x00, 0xBE, 0x9B),
> +       _INIT_CMD(0x00, 0xBF, 0x0C),
> +       _INIT_CMD(0x00, 0xC0, 0x3D),
> +       _INIT_CMD(0x00, 0xC1, 0x71),
> +       _INIT_CMD(0x00, 0xC2, 0x90),
> +       _INIT_CMD(0x00, 0xC3, 0xA0),
> +       _INIT_CMD(0x00, 0xC4, 0xA8),
> +       _INIT_CMD(0x00, 0xC5, 0xB1),
> +       _INIT_CMD(0x00, 0xC6, 0xBB),
> +       _INIT_CMD(0x00, 0xC7, 0xC0),
> +       _INIT_CMD(0x00, 0xC8, 0xC4),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xCA, 0x00),
> +       _INIT_CMD(0x00, 0xCB, 0x16),
> +       _INIT_CMD(0x00, 0xCC, 0xAF),
> +       _INIT_CMD(0x00, 0xCD, 0xFF),
> +       _INIT_CMD(0x00, 0xCE, 0xFF),
> +       _INIT_CMD(0x00, 0xB0, 0x08),
> +       _INIT_CMD(0x00, 0xB1, 0x04),
> +       _INIT_CMD(0x00, 0xB2, 0x08),
> +       _INIT_CMD(0x00, 0xB3, 0x19),
> +       _INIT_CMD(0x00, 0xB4, 0x31),
> +       _INIT_CMD(0x00, 0xB5, 0x46),
> +       _INIT_CMD(0x00, 0xB6, 0x55),
> +       _INIT_CMD(0x00, 0xB7, 0x6E),
> +       _INIT_CMD(0x00, 0xB8, 0x92),
> +       _INIT_CMD(0x00, 0xB9, 0xD4),
> +       _INIT_CMD(0x00, 0xBA, 0x1B),
> +       _INIT_CMD(0x05, 0xBB, 0x9B),
> +       _INIT_CMD(0x00, 0xBC, 0x28),
> +       _INIT_CMD(0x00, 0xBD, 0x2D),
> +       _INIT_CMD(0x00, 0xBE, 0xC3),
> +       _INIT_CMD(0x00, 0xBF, 0x2F),
> +       _INIT_CMD(0x00, 0xC0, 0x62),
> +       _INIT_CMD(0x00, 0xC1, 0x99),
> +       _INIT_CMD(0x00, 0xC2, 0xAB),
> +       _INIT_CMD(0x00, 0xC3, 0xBF),
> +       _INIT_CMD(0x00, 0xC4, 0xCF),
> +       _INIT_CMD(0x00, 0xC5, 0xDF),
> +       _INIT_CMD(0x00, 0xC6, 0xF0),
> +       _INIT_CMD(0x00, 0xC7, 0xF9),
> +       _INIT_CMD(0x00, 0xC8, 0xFC),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xCA, 0x00),
> +       _INIT_CMD(0x00, 0xCB, 0x16),
> +       _INIT_CMD(0x00, 0xCC, 0xAF),
> +       _INIT_CMD(0x00, 0xCD, 0xFF),
> +       _INIT_CMD(0x00, 0xCE, 0xFF),
> +       _INIT_CMD(0x00, 0xB0, 0x09),
> +       _INIT_CMD(0x00, 0xB1, 0x04),
> +       _INIT_CMD(0x00, 0xB2, 0x05),
> +       _INIT_CMD(0x00, 0xB3, 0x17),
> +       _INIT_CMD(0x00, 0xB4, 0x2E),
> +       _INIT_CMD(0x00, 0xB5, 0x42),
> +       _INIT_CMD(0x00, 0xB6, 0x51),
> +       _INIT_CMD(0x00, 0xB7, 0x69),
> +       _INIT_CMD(0x00, 0xB8, 0x88),
> +       _INIT_CMD(0x00, 0xB9, 0xC9),
> +       _INIT_CMD(0x00, 0xBA, 0x0C),
> +       _INIT_CMD(0x05, 0xBB, 0x86),
> +       _INIT_CMD(0x00, 0xBC, 0x03),
> +       _INIT_CMD(0x00, 0xBD, 0x08),
> +       _INIT_CMD(0x00, 0xBE, 0x95),
> +       _INIT_CMD(0x00, 0xBF, 0x05),
> +       _INIT_CMD(0x00, 0xC0, 0x35),
> +       _INIT_CMD(0x00, 0xC1, 0x62),
> +       _INIT_CMD(0x00, 0xC2, 0x81),
> +       _INIT_CMD(0x00, 0xC3, 0x96),
> +       _INIT_CMD(0x00, 0xC4, 0x9E),
> +       _INIT_CMD(0x00, 0xC5, 0xA5),
> +       _INIT_CMD(0x00, 0xC6, 0xAD),
> +       _INIT_CMD(0x00, 0xC7, 0xB1),
> +       _INIT_CMD(0x00, 0xC8, 0xB4),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xCA, 0x00),
> +       _INIT_CMD(0x00, 0xCB, 0x16),
> +       _INIT_CMD(0x00, 0xCC, 0xAF),
> +       _INIT_CMD(0x00, 0xCD, 0xFF),
> +       _INIT_CMD(0x00, 0xCE, 0xFF),
> +       _INIT_CMD(0x00, 0xB0, 0x0A),
> +       _INIT_CMD(0x00, 0xB1, 0x00),
> +       _INIT_CMD(0x00, 0xB2, 0x09),
> +       _INIT_CMD(0x00, 0xB3, 0x19),
> +       _INIT_CMD(0x00, 0xB4, 0x2F),
> +       _INIT_CMD(0x00, 0xB5, 0x44),
> +       _INIT_CMD(0x00, 0xB6, 0x52),
> +       _INIT_CMD(0x00, 0xB7, 0x6A),
> +       _INIT_CMD(0x00, 0xB8, 0x8A),
> +       _INIT_CMD(0x00, 0xB9, 0xCA),
> +       _INIT_CMD(0x00, 0xBA, 0x0C),
> +       _INIT_CMD(0x05, 0xBB, 0x87),
> +       _INIT_CMD(0x00, 0xBC, 0x06),
> +       _INIT_CMD(0x00, 0xBD, 0x0A),
> +       _INIT_CMD(0x00, 0xBE, 0x9B),
> +       _INIT_CMD(0x00, 0xBF, 0x0C),
> +       _INIT_CMD(0x00, 0xC0, 0x3D),
> +       _INIT_CMD(0x00, 0xC1, 0x71),
> +       _INIT_CMD(0x00, 0xC2, 0x90),
> +       _INIT_CMD(0x00, 0xC3, 0xA0),
> +       _INIT_CMD(0x00, 0xC4, 0xA8),
> +       _INIT_CMD(0x00, 0xC5, 0xB1),
> +       _INIT_CMD(0x00, 0xC6, 0xBB),
> +       _INIT_CMD(0x00, 0xC7, 0xC0),
> +       _INIT_CMD(0x00, 0xC8, 0xC4),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xCA, 0x00),
> +       _INIT_CMD(0x00, 0xCB, 0x16),
> +       _INIT_CMD(0x00, 0xCC, 0xAF),
> +       _INIT_CMD(0x00, 0xCD, 0xFF),
> +       _INIT_CMD(0x00, 0xCE, 0xFF),
> +       _INIT_CMD(0x00, 0xB0, 0x0B),
> +       _INIT_CMD(0x00, 0xB1, 0x04),
> +       _INIT_CMD(0x00, 0xB2, 0x08),
> +       _INIT_CMD(0x00, 0xB3, 0x19),
> +       _INIT_CMD(0x00, 0xB4, 0x31),
> +       _INIT_CMD(0x00, 0xB5, 0x46),
> +       _INIT_CMD(0x00, 0xB6, 0x55),
> +       _INIT_CMD(0x00, 0xB7, 0x6E),
> +       _INIT_CMD(0x00, 0xB8, 0x92),
> +       _INIT_CMD(0x00, 0xB9, 0xD4),
> +       _INIT_CMD(0x00, 0xBA, 0x1B),
> +       _INIT_CMD(0x05, 0xBB, 0x9B),
> +       _INIT_CMD(0x00, 0xBC, 0x28),
> +       _INIT_CMD(0x00, 0xBD, 0x2D),
> +       _INIT_CMD(0x00, 0xBE, 0xC3),
> +       _INIT_CMD(0x00, 0xBF, 0x2F),
> +       _INIT_CMD(0x00, 0xC0, 0x62),
> +       _INIT_CMD(0x00, 0xC1, 0x99),
> +       _INIT_CMD(0x00, 0xC2, 0xAB),
> +       _INIT_CMD(0x00, 0xC3, 0xBF),
> +       _INIT_CMD(0x00, 0xC4, 0xCF),
> +       _INIT_CMD(0x00, 0xC5, 0xDF),
> +       _INIT_CMD(0x00, 0xC6, 0xF0),
> +       _INIT_CMD(0x00, 0xC7, 0xF9),
> +       _INIT_CMD(0x00, 0xC8, 0xFC),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xCA, 0x00),
> +       _INIT_CMD(0x00, 0xCB, 0x16),
> +       _INIT_CMD(0x00, 0xCC, 0xAF),
> +       _INIT_CMD(0x00, 0xCD, 0xFF),
> +       _INIT_CMD(0x00, 0xCE, 0xFF),
> +       _INIT_CMD(0x00, 0xB0, 0x0C),
> +       _INIT_CMD(0x00, 0xB1, 0x04),
> +       _INIT_CMD(0x00, 0xB2, 0x05),
> +       _INIT_CMD(0x00, 0xB3, 0x17),
> +       _INIT_CMD(0x00, 0xB4, 0x2E),
> +       _INIT_CMD(0x00, 0xB5, 0x42),
> +       _INIT_CMD(0x00, 0xB6, 0x51),
> +       _INIT_CMD(0x00, 0xB7, 0x69),
> +       _INIT_CMD(0x00, 0xB8, 0x88),
> +       _INIT_CMD(0x00, 0xB9, 0xC9),
> +       _INIT_CMD(0x00, 0xBA, 0x0C),
> +       _INIT_CMD(0x05, 0xBB, 0x86),
> +       _INIT_CMD(0x00, 0xBC, 0x03),
> +       _INIT_CMD(0x00, 0xBD, 0x08),
> +       _INIT_CMD(0x00, 0xBE, 0x95),
> +       _INIT_CMD(0x00, 0xBF, 0x05),
> +       _INIT_CMD(0x00, 0xC0, 0x35),
> +       _INIT_CMD(0x00, 0xC1, 0x62),
> +       _INIT_CMD(0x00, 0xC2, 0x81),
> +       _INIT_CMD(0x00, 0xC3, 0x96),
> +       _INIT_CMD(0x00, 0xC4, 0x9E),
> +       _INIT_CMD(0x00, 0xC5, 0xA5),
> +       _INIT_CMD(0x00, 0xC6, 0xAD),
> +       _INIT_CMD(0x00, 0xC7, 0xB1),
> +       _INIT_CMD(0x00, 0xC8, 0xB4),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xCA, 0x00),
> +       _INIT_CMD(0x00, 0xCB, 0x16),
> +       _INIT_CMD(0x00, 0xCC, 0xAF),
> +       _INIT_CMD(0x00, 0xCD, 0xFF),
> +       _INIT_CMD(0x64, 0xCE, 0xFF),
> +       _INIT_CMD(0x00, 0xB0, 0x00),
> +       _INIT_CMD(0x00, 0xB3, 0x08),
> +       _INIT_CMD(0x00, 0xB0, 0x04),
> +       _INIT_CMD(0x0A, 0xB8, 0x68),
> +       _INIT_CMD(0x78, 0x11),
> +       _INIT_CMD(0x14, 0x29),
> +
> +       {},
> +};
> +
> +static const struct panel_desc boe_himax8279d8p_panel_desc = {
> +       .display_mode = &default_display_mode,
> +       .bpc = 8,
> +       .width_mm = 107,
> +       .height_mm = 172,
> +       .delay_t1 = 5000,
> +       .reset_delay_t2 = 14000,
> +       .reset_delay_t3 = 1000,
> +       .reset_delay_t4 = 1000,
> +       .reset_delay_t5 = 5000,
> +       .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> +                       MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM,
> +       .format = MIPI_DSI_FMT_RGB888,
> +       .lanes = 4,
> +       .on_cmds = boe_himax8279d8p_on_cmds,
> +       .off_cmds = default_off_cmds,
> +};
> +
> +/* 10 inch */
> +static const struct panel_cmd boe_himax8279d10p_on_cmds[] = {
> +       _INIT_CMD(0x00, 0xB0, 0x05),
> +       _INIT_CMD(0x00, 0xB1, 0xE5),
> +       _INIT_CMD(0x00, 0xB3, 0x52),
> +       _INIT_CMD(0x00, 0xB0, 0x00),
> +       _INIT_CMD(0x00, 0xB3, 0x88),
> +       _INIT_CMD(0x00, 0xB0, 0x04),
> +       _INIT_CMD(0x00, 0xB8, 0x00),
> +       _INIT_CMD(0x00, 0xB0, 0x00),
> +       _INIT_CMD(0x00, 0xB2, 0x50),
> +       _INIT_CMD(0x00, 0xB6, 0x03),
> +       _INIT_CMD(0x00, 0xBA, 0x8B),
> +       _INIT_CMD(0x00, 0xBF, 0x1A),
> +       _INIT_CMD(0x00, 0xC0, 0x0F),
> +       _INIT_CMD(0x00, 0xC2, 0x0C),
> +       _INIT_CMD(0x00, 0xC3, 0x02),
> +       _INIT_CMD(0x00, 0xC4, 0x0C),
> +       _INIT_CMD(0x00, 0xC5, 0x02),
> +       _INIT_CMD(0x00, 0xB0, 0x01),
> +       _INIT_CMD(0x00, 0xE0, 0x26),
> +       _INIT_CMD(0x00, 0xE1, 0x26),
> +       _INIT_CMD(0x00, 0xDC, 0x00),
> +       _INIT_CMD(0x00, 0xDD, 0x00),
> +       _INIT_CMD(0x00, 0xCC, 0x26),
> +       _INIT_CMD(0x00, 0xCD, 0x26),
> +       _INIT_CMD(0x00, 0xC8, 0x00),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xD2, 0x04),
> +       _INIT_CMD(0x00, 0xD3, 0x04),
> +       _INIT_CMD(0x00, 0xE6, 0x03),
> +       _INIT_CMD(0x00, 0xE7, 0x03),
> +       _INIT_CMD(0x00, 0xC4, 0x08),
> +       _INIT_CMD(0x00, 0xC5, 0x08),
> +       _INIT_CMD(0x00, 0xD8, 0x07),
> +       _INIT_CMD(0x00, 0xD9, 0x07),
> +       _INIT_CMD(0x00, 0xC2, 0x06),
> +       _INIT_CMD(0x00, 0xC3, 0x06),
> +       _INIT_CMD(0x00, 0xD6, 0x05),
> +       _INIT_CMD(0x00, 0xD7, 0x05),
> +       _INIT_CMD(0x00, 0xC0, 0x0C),
> +       _INIT_CMD(0x00, 0xC1, 0x0C),
> +       _INIT_CMD(0x00, 0xD4, 0x0B),
> +       _INIT_CMD(0x00, 0xD5, 0x0B),
> +       _INIT_CMD(0x00, 0xCA, 0x0A),
> +       _INIT_CMD(0x00, 0xCB, 0x0A),
> +       _INIT_CMD(0x00, 0xDE, 0x09),
> +       _INIT_CMD(0x00, 0xDF, 0x09),
> +       _INIT_CMD(0x00, 0xC6, 0x26),
> +       _INIT_CMD(0x00, 0xC7, 0x26),
> +       _INIT_CMD(0x00, 0xCE, 0x00),
> +       _INIT_CMD(0x00, 0xCF, 0x00),
> +       _INIT_CMD(0x00, 0xDA, 0x26),
> +       _INIT_CMD(0x00, 0xDB, 0x26),
> +       _INIT_CMD(0x00, 0xE2, 0x00),
> +       _INIT_CMD(0x00, 0xE3, 0x00),
> +       _INIT_CMD(0x00, 0xB0, 0x02),
> +       _INIT_CMD(0x00, 0xC0, 0x00),
> +       _INIT_CMD(0x00, 0xC1, 0x07),
> +       _INIT_CMD(0x00, 0xC2, 0x0D),
> +       _INIT_CMD(0x00, 0xC3, 0x18),
> +       _INIT_CMD(0x00, 0xC4, 0x27),
> +       _INIT_CMD(0x00, 0xC5, 0x28),
> +       _INIT_CMD(0x00, 0xC6, 0x30),
> +       _INIT_CMD(0x00, 0xC7, 0x2E),
> +       _INIT_CMD(0x00, 0xC8, 0x2F),
> +       _INIT_CMD(0x00, 0xC9, 0x1A),
> +       _INIT_CMD(0x00, 0xCA, 0x20),
> +       _INIT_CMD(0x00, 0xCB, 0x29),
> +       _INIT_CMD(0x00, 0xCC, 0x26),
> +       _INIT_CMD(0x00, 0xCD, 0x32),
> +       _INIT_CMD(0x00, 0xCE, 0x33),
> +       _INIT_CMD(0x00, 0xCF, 0x31),
> +       _INIT_CMD(0x00, 0xD0, 0x06),
> +       _INIT_CMD(0x00, 0xD2, 0x00),
> +       _INIT_CMD(0x00, 0xD3, 0x07),
> +       _INIT_CMD(0x00, 0xD4, 0x12),
> +       _INIT_CMD(0x00, 0xD5, 0x26),
> +       _INIT_CMD(0x00, 0xD6, 0x3D),
> +       _INIT_CMD(0x00, 0xD7, 0x3F),
> +       _INIT_CMD(0x00, 0xD8, 0x3F),
> +       _INIT_CMD(0x00, 0xD9, 0x3F),
> +       _INIT_CMD(0x00, 0xDA, 0x3F),
> +       _INIT_CMD(0x00, 0xDB, 0x3F),
> +       _INIT_CMD(0x00, 0xDC, 0x3F),
> +       _INIT_CMD(0x00, 0xDD, 0x3F),
> +       _INIT_CMD(0x00, 0xDE, 0x3F),
> +       _INIT_CMD(0x00, 0xDF, 0x3A),
> +       _INIT_CMD(0x00, 0xE0, 0x37),
> +       _INIT_CMD(0x00, 0xE1, 0x35),
> +       _INIT_CMD(0x00, 0xE2, 0x07),
> +       _INIT_CMD(0x00, 0xB0, 0x03),
> +       _INIT_CMD(0x00, 0xC8, 0x0B),
> +       _INIT_CMD(0x00, 0xC9, 0x07),
> +       _INIT_CMD(0x00, 0xC3, 0x00),
> +       _INIT_CMD(0x00, 0xE7, 0x00),
> +       _INIT_CMD(0x00, 0xC5, 0x2A),
> +       _INIT_CMD(0x00, 0xDE, 0x2A),
> +       _INIT_CMD(0x00, 0xCA, 0x43),
> +       _INIT_CMD(0x00, 0xC9, 0x07),
> +       _INIT_CMD(0x00, 0xE4, 0xC0),
> +       _INIT_CMD(0x00, 0xE5, 0x0D),
> +       _INIT_CMD(0x00, 0xCB, 0x00),
> +       _INIT_CMD(0x00, 0xB0, 0x06),
> +       _INIT_CMD(0x00, 0xB8, 0xA5),
> +       _INIT_CMD(0x00, 0xC0, 0xA5),
> +       _INIT_CMD(0x00, 0xC7, 0x0F),
> +       _INIT_CMD(0x00, 0xD5, 0x32),
> +       _INIT_CMD(0x00, 0xB8, 0x00),
> +       _INIT_CMD(0x00, 0xC0, 0x00),
> +       _INIT_CMD(0x00, 0xBC, 0x00),
> +       _INIT_CMD(0x00, 0xB0, 0x07),
> +       _INIT_CMD(0x00, 0xB1, 0x00),
> +       _INIT_CMD(0x00, 0xB2, 0x09),
> +       _INIT_CMD(0x00, 0xB3, 0x19),
> +       _INIT_CMD(0x00, 0xB4, 0x2F),
> +       _INIT_CMD(0x00, 0xB5, 0x44),
> +       _INIT_CMD(0x00, 0xB6, 0x52),
> +       _INIT_CMD(0x00, 0xB7, 0x6A),
> +       _INIT_CMD(0x00, 0xB8, 0x8A),
> +       _INIT_CMD(0x00, 0xB9, 0xCA),
> +       _INIT_CMD(0x00, 0xBA, 0x0C),
> +       _INIT_CMD(0x00, 0xBB, 0x87),
> +       _INIT_CMD(0x00, 0xBC, 0x06),
> +       _INIT_CMD(0x00, 0xBD, 0x0A),
> +       _INIT_CMD(0x00, 0xBE, 0x9B),
> +       _INIT_CMD(0x00, 0xBF, 0x0C),
> +       _INIT_CMD(0x00, 0xC0, 0x3D),
> +       _INIT_CMD(0x00, 0xC1, 0x71),
> +       _INIT_CMD(0x00, 0xC2, 0x90),
> +       _INIT_CMD(0x00, 0xC3, 0xA0),
> +       _INIT_CMD(0x00, 0xC4, 0xA8),
> +       _INIT_CMD(0x00, 0xC5, 0xB1),
> +       _INIT_CMD(0x00, 0xC6, 0xBB),
> +       _INIT_CMD(0x00, 0xC7, 0xC0),
> +       _INIT_CMD(0x00, 0xC8, 0xC4),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xCA, 0x00),
> +       _INIT_CMD(0x00, 0xCB, 0x16),
> +       _INIT_CMD(0x00, 0xCC, 0xAF),
> +       _INIT_CMD(0x00, 0xCD, 0xFF),
> +       _INIT_CMD(0x00, 0xCE, 0xFF),
> +       _INIT_CMD(0x00, 0xB0, 0x08),
> +       _INIT_CMD(0x00, 0xB1, 0x04),
> +       _INIT_CMD(0x00, 0xB2, 0x08),
> +       _INIT_CMD(0x00, 0xB3, 0x19),
> +       _INIT_CMD(0x00, 0xB4, 0x31),
> +       _INIT_CMD(0x00, 0xB5, 0x46),
> +       _INIT_CMD(0x00, 0xB6, 0x55),
> +       _INIT_CMD(0x00, 0xB7, 0x6E),
> +       _INIT_CMD(0x00, 0xB8, 0x92),
> +       _INIT_CMD(0x00, 0xB9, 0xD4),
> +       _INIT_CMD(0x00, 0xBA, 0x1B),
> +       _INIT_CMD(0x00, 0xBB, 0x9B),
> +       _INIT_CMD(0x00, 0xBC, 0x28),
> +       _INIT_CMD(0x00, 0xBD, 0x2D),
> +       _INIT_CMD(0x00, 0xBE, 0xC3),
> +       _INIT_CMD(0x00, 0xBF, 0x2F),
> +       _INIT_CMD(0x00, 0xC0, 0x62),
> +       _INIT_CMD(0x00, 0xC1, 0x99),
> +       _INIT_CMD(0x00, 0xC2, 0xAB),
> +       _INIT_CMD(0x00, 0xC3, 0xBF),
> +       _INIT_CMD(0x00, 0xC4, 0xCF),
> +       _INIT_CMD(0x00, 0xC5, 0xDF),
> +       _INIT_CMD(0x00, 0xC6, 0xF0),
> +       _INIT_CMD(0x00, 0xC7, 0xF9),
> +       _INIT_CMD(0x00, 0xC8, 0xFC),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xCA, 0x00),
> +       _INIT_CMD(0x00, 0xCB, 0x16),
> +       _INIT_CMD(0x00, 0xCC, 0xAF),
> +       _INIT_CMD(0x00, 0xCD, 0xFF),
> +       _INIT_CMD(0x00, 0xCE, 0xFF),
> +       _INIT_CMD(0x00, 0xB0, 0x09),
> +       _INIT_CMD(0x00, 0xB1, 0x04),
> +       _INIT_CMD(0x00, 0xB2, 0x05),
> +       _INIT_CMD(0x00, 0xB3, 0x17),
> +       _INIT_CMD(0x00, 0xB4, 0x2E),
> +       _INIT_CMD(0x00, 0xB5, 0x42),
> +       _INIT_CMD(0x00, 0xB6, 0x51),
> +       _INIT_CMD(0x00, 0xB7, 0x69),
> +       _INIT_CMD(0x00, 0xB8, 0x88),
> +       _INIT_CMD(0x00, 0xB9, 0xC9),
> +       _INIT_CMD(0x00, 0xBA, 0x0C),
> +       _INIT_CMD(0x00, 0xBB, 0x86),
> +       _INIT_CMD(0x00, 0xBC, 0x03),
> +       _INIT_CMD(0x00, 0xBD, 0x08),
> +       _INIT_CMD(0x00, 0xBE, 0x95),
> +       _INIT_CMD(0x00, 0xBF, 0x05),
> +       _INIT_CMD(0x00, 0xC0, 0x35),
> +       _INIT_CMD(0x00, 0xC1, 0x62),
> +       _INIT_CMD(0x00, 0xC2, 0x81),
> +       _INIT_CMD(0x00, 0xC3, 0x96),
> +       _INIT_CMD(0x00, 0xC4, 0x9E),
> +       _INIT_CMD(0x00, 0xC5, 0xA5),
> +       _INIT_CMD(0x00, 0xC6, 0xAD),
> +       _INIT_CMD(0x00, 0xC7, 0xB1),
> +       _INIT_CMD(0x00, 0xC8, 0xB4),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xCA, 0x00),
> +       _INIT_CMD(0x00, 0xCB, 0x16),
> +       _INIT_CMD(0x00, 0xCC, 0xAF),
> +       _INIT_CMD(0x00, 0xCD, 0xFF),
> +       _INIT_CMD(0x00, 0xCE, 0xFF),
> +       _INIT_CMD(0x00, 0xB0, 0x0A),
> +       _INIT_CMD(0x00, 0xB1, 0x00),
> +       _INIT_CMD(0x00, 0xB2, 0x09),
> +       _INIT_CMD(0x00, 0xB3, 0x19),
> +       _INIT_CMD(0x00, 0xB4, 0x2F),
> +       _INIT_CMD(0x00, 0xB5, 0x44),
> +       _INIT_CMD(0x00, 0xB6, 0x52),
> +       _INIT_CMD(0x00, 0xB7, 0x6A),
> +       _INIT_CMD(0x00, 0xB8, 0x8A),
> +       _INIT_CMD(0x00, 0xB9, 0xCA),
> +       _INIT_CMD(0x00, 0xBA, 0x0C),
> +       _INIT_CMD(0x00, 0xBB, 0x87),
> +       _INIT_CMD(0x00, 0xBC, 0x06),
> +       _INIT_CMD(0x00, 0xBD, 0x0A),
> +       _INIT_CMD(0x00, 0xBE, 0x9B),
> +       _INIT_CMD(0x00, 0xBF, 0x0C),
> +       _INIT_CMD(0x00, 0xC0, 0x3D),
> +       _INIT_CMD(0x00, 0xC1, 0x71),
> +       _INIT_CMD(0x00, 0xC2, 0x90),
> +       _INIT_CMD(0x00, 0xC3, 0xA0),
> +       _INIT_CMD(0x00, 0xC4, 0xA8),
> +       _INIT_CMD(0x00, 0xC5, 0xB1),
> +       _INIT_CMD(0x00, 0xC6, 0xBB),
> +       _INIT_CMD(0x00, 0xC7, 0xC0),
> +       _INIT_CMD(0x00, 0xC8, 0xC4),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xCA, 0x00),
> +       _INIT_CMD(0x00, 0xCB, 0x16),
> +       _INIT_CMD(0x00, 0xCC, 0xAF),
> +       _INIT_CMD(0x00, 0xCD, 0xFF),
> +       _INIT_CMD(0x00, 0xCE, 0xFF),
> +       _INIT_CMD(0x00, 0xB0, 0x0B),
> +       _INIT_CMD(0x00, 0xB1, 0x04),
> +       _INIT_CMD(0x00, 0xB2, 0x08),
> +       _INIT_CMD(0x00, 0xB3, 0x19),
> +       _INIT_CMD(0x00, 0xB4, 0x31),
> +       _INIT_CMD(0x00, 0xB5, 0x46),
> +       _INIT_CMD(0x00, 0xB6, 0x55),
> +       _INIT_CMD(0x00, 0xB7, 0x6E),
> +       _INIT_CMD(0x00, 0xB8, 0x92),
> +       _INIT_CMD(0x00, 0xB9, 0xD4),
> +       _INIT_CMD(0x00, 0xBA, 0x1B),
> +       _INIT_CMD(0x00, 0xBB, 0x9B),
> +       _INIT_CMD(0x00, 0xBC, 0x28),
> +       _INIT_CMD(0x00, 0xBD, 0x2D),
> +       _INIT_CMD(0x00, 0xBE, 0xC3),
> +       _INIT_CMD(0x00, 0xBF, 0x2F),
> +       _INIT_CMD(0x00, 0xC0, 0x62),
> +       _INIT_CMD(0x00, 0xC1, 0x99),
> +       _INIT_CMD(0x00, 0xC2, 0xAB),
> +       _INIT_CMD(0x00, 0xC3, 0xBF),
> +       _INIT_CMD(0x00, 0xC4, 0xCF),
> +       _INIT_CMD(0x00, 0xC5, 0xDF),
> +       _INIT_CMD(0x00, 0xC6, 0xF0),
> +       _INIT_CMD(0x00, 0xC7, 0xF9),
> +       _INIT_CMD(0x00, 0xC8, 0xFC),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xCA, 0x00),
> +       _INIT_CMD(0x00, 0xCB, 0x16),
> +       _INIT_CMD(0x00, 0xCC, 0xAF),
> +       _INIT_CMD(0x00, 0xCD, 0xFF),
> +       _INIT_CMD(0x00, 0xCE, 0xFF),
> +       _INIT_CMD(0x00, 0xB0, 0x0C),
> +       _INIT_CMD(0x00, 0xB1, 0x04),
> +       _INIT_CMD(0x00, 0xB2, 0x05),
> +       _INIT_CMD(0x00, 0xB3, 0x17),
> +       _INIT_CMD(0x00, 0xB4, 0x2E),
> +       _INIT_CMD(0x00, 0xB5, 0x42),
> +       _INIT_CMD(0x00, 0xB6, 0x51),
> +       _INIT_CMD(0x00, 0xB7, 0x69),
> +       _INIT_CMD(0x00, 0xB8, 0x88),
> +       _INIT_CMD(0x00, 0xB9, 0xC9),
> +       _INIT_CMD(0x00, 0xBA, 0x0C),
> +       _INIT_CMD(0x00, 0xBB, 0x86),
> +       _INIT_CMD(0x00, 0xBC, 0x03),
> +       _INIT_CMD(0x00, 0xBD, 0x08),
> +       _INIT_CMD(0x00, 0xBE, 0x95),
> +       _INIT_CMD(0x00, 0xBF, 0x05),
> +       _INIT_CMD(0x00, 0xC0, 0x35),
> +       _INIT_CMD(0x00, 0xC1, 0x62),
> +       _INIT_CMD(0x00, 0xC2, 0x81),
> +       _INIT_CMD(0x00, 0xC3, 0x96),
> +       _INIT_CMD(0x00, 0xC4, 0x9E),
> +       _INIT_CMD(0x00, 0xC5, 0xA5),
> +       _INIT_CMD(0x00, 0xC6, 0xAD),
> +       _INIT_CMD(0x00, 0xC7, 0xB1),
> +       _INIT_CMD(0x00, 0xC8, 0xB4),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xCA, 0x00),
> +       _INIT_CMD(0x00, 0xCB, 0x16),
> +       _INIT_CMD(0x00, 0xCC, 0xAF),
> +       _INIT_CMD(0x00, 0xCD, 0xFF),
> +       _INIT_CMD(0x00, 0xCE, 0xFF),
> +       _INIT_CMD(0x00, 0xB0, 0x00),
> +       _INIT_CMD(0x00, 0xB3, 0x08),
> +       _INIT_CMD(0x00, 0xB0, 0x04),
> +       _INIT_CMD(0x64, 0xB8, 0x68),
> +
> +       {},
> +};
> +
> +static const struct panel_desc boe_himax8279d10p_panel_desc = {
> +       .display_mode = &default_display_mode,
> +       .bpc = 8,
> +       .width_mm = 135,
> +       .height_mm = 216,
> +       .delay_t1 = 5000,
> +       .reset_delay_t2 = 14000,
> +       .reset_delay_t3 = 1000,
> +       .reset_delay_t4 = 1000,
> +       .reset_delay_t5 = 5000,
> +       .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> +                       MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM,
> +       .format = MIPI_DSI_FMT_RGB888,
> +       .lanes = 4,
> +       .on_cmds = boe_himax8279d10p_on_cmds,
> +       .off_cmds = default_off_cmds,
> +};
> +
> +static const struct of_device_id panel_of_match[] = {
> +       { .compatible = "boe,himax8279d8p",
> +         .data = &boe_himax8279d8p_panel_desc
> +       }, { .compatible = "boe,himax8279d10p",
> +         .data = &boe_himax8279d10p_panel_desc
> +       }, {
> +               /* sentinel */
> +       }
> +};
> +MODULE_DEVICE_TABLE(of, panel_of_match);
> +
> +static int panel_add(struct panel_info *pinfo)
> +{
> +       struct device *dev = &pinfo->link->dev;
> +       int ret;
> +
> +       pinfo->pp18_gpio = devm_gpiod_get_optional(dev, "pp18", GPIOD_OUT_HIGH);
> +       if (IS_ERR(pinfo->pp18_gpio)) {
> +               ret = PTR_ERR(pinfo->pp18_gpio);
> +               if (ret != -EPROBE_DEFER)
> +                       DRM_DEV_ERROR(dev, "failed to get pp18 gpio: %d\n",
> +                                       ret);
> +               return ret;
> +       }
> +
> +       pinfo->pp33_gpio = devm_gpiod_get_optional(dev, "pp33", GPIOD_OUT_HIGH);
> +       if (IS_ERR(pinfo->pp33_gpio)) {
> +               ret = PTR_ERR(pinfo->pp33_gpio);
> +               if (ret != -EPROBE_DEFER)
> +                       DRM_DEV_ERROR(dev, "failed to get pp33 gpio: %d\n",
> +                                       ret);
> +               return ret;
> +       }
> +
> +       pinfo->enable_gpio = devm_gpiod_get_optional(dev, "enable",
> +                                                       GPIOD_OUT_HIGH);
> +       if (IS_ERR(pinfo->enable_gpio)) {
> +               ret = PTR_ERR(pinfo->enable_gpio);
> +               if (ret != -EPROBE_DEFER)
> +                       DRM_DEV_ERROR(dev, "failed to get enable gpio: %d\n",
> +                                       ret);
> +               return ret;
> +       }
> +
> +       pinfo->backlight = devm_of_find_backlight(dev);
> +       if (IS_ERR(pinfo->backlight))
> +               return PTR_ERR(pinfo->backlight);
> +
> +       drm_panel_init(&pinfo->base);
> +       pinfo->base.funcs = &panel_funcs;
> +       pinfo->base.dev = &pinfo->link->dev;
> +
> +       ret = drm_panel_add(&pinfo->base);
> +       if (ret < 0)
> +               return ret;
> +
> +       return 0;
> +}
> +
> +static void panel_del(struct panel_info *pinfo)
> +{
> +       if (pinfo->base.dev)
> +               drm_panel_remove(&pinfo->base);
> +}
> +
> +static int panel_probe(struct mipi_dsi_device *dsi)
> +{
> +       struct panel_info *pinfo;
> +       const struct panel_desc *desc;
> +       int err;
> +
> +       pinfo = devm_kzalloc(&dsi->dev, sizeof(*pinfo), GFP_KERNEL);
> +       if (!pinfo)
> +               return -ENOMEM;
> +
> +       desc = of_device_get_match_data(&dsi->dev);
> +       dsi->mode_flags = desc->mode_flags;
> +       dsi->format = desc->format;
> +       dsi->lanes = desc->lanes;
> +       pinfo->desc = desc;
> +
> +       pinfo->link = dsi;
> +       mipi_dsi_set_drvdata(dsi, pinfo);
> +
> +       err = panel_add(pinfo);
> +       if (err < 0)
> +               return err;
> +
> +       return mipi_dsi_attach(dsi);
> +}
> +
> +static int panel_remove(struct mipi_dsi_device *dsi)
> +{
> +       struct panel_info *pinfo = mipi_dsi_get_drvdata(dsi);
> +       int err;
> +
> +       err = boe_panel_unprepare(&pinfo->base);
> +       if (err < 0)
> +               DRM_DEV_ERROR(&dsi->dev, "failed to unprepare panel: %d\n",
> +                               err);
> +
> +       err = boe_panel_disable(&pinfo->base);
> +       if (err < 0)
> +               DRM_DEV_ERROR(&dsi->dev, "failed to disable panel: %d\n", err);
> +
> +       err = mipi_dsi_detach(dsi);
> +       if (err < 0)
> +               DRM_DEV_ERROR(&dsi->dev, "failed to detach from DSI host: %d\n",
> +                               err);
> +
> +       drm_panel_detach(&pinfo->base);
> +       panel_del(pinfo);
> +
> +       return 0;
> +}
> +
> +static void panel_shutdown(struct mipi_dsi_device *dsi)
> +{
> +       struct panel_info *pinfo = mipi_dsi_get_drvdata(dsi);
> +
> +       boe_panel_disable(&pinfo->base);
> +       boe_panel_unprepare(&pinfo->base);
> +}
> +
> +static struct mipi_dsi_driver panel_driver = {
> +       .driver = {
> +               .name = "panel-boe-himax8279d",
> +               .of_match_table = panel_of_match,
> +       },
> +       .probe = panel_probe,
> +       .remove = panel_remove,
> +       .shutdown = panel_shutdown,
> +};
> +module_mipi_dsi_driver(panel_driver);
> +
> +MODULE_AUTHOR("Jerry Han <hanxu5 at huaqin.corp-partner.google.com>");
> +MODULE_DESCRIPTION("Boe Himax8279d driver");
> +MODULE_LICENSE("GPL v2");
> --
> 2.17.1
>


More information about the dri-devel mailing list