[PATCH] drm: Some ocd in drm_file.c

Chris Wilson chris at chris-wilson.co.uk
Thu May 2 07:32:02 UTC 2019


Quoting Daniel Vetter (2019-05-02 08:27:27)
> +static int drm_legacy_setup(struct drm_device * dev)
> +{
> +       int ret;
> +
> +       if (dev->driver->firstopen &&
> +           drm_core_check_feature(dev, DRIVER_LEGACY)) {
> +               ret = dev->driver->firstopen(dev);
> +               if (ret != 0)
> +                       return ret;
> +       }

Did airlied land his patch to move legacy to a separate compilation
unit? If so, we could move this away and the compiler would have a field
day simplifying drm_open().
-Chris


More information about the dri-devel mailing list