[PATCH] drm/virtio: allocate fences with GFP_KERNEL

Robert Foss robert.foss at collabora.com
Fri May 3 14:47:17 UTC 2019


On 03.05.19 16:31, Emil Velikov wrote:
> On Mon, 29 Apr 2019 at 23:10, Chia-I Wu <olvaffe at gmail.com> wrote:
>>
>> It was changed to GFP_ATOMIC in commit ec2f0577c (add & use
>> virtio_gpu_queue_fenced_ctrl_buffer) because the allocation happened
>> with a spinlock held.  That was no longer true after commit
>> 9fdd90c0f (add virtio_gpu_alloc_fence()).
>>
>> Signed-off-by: Chia-I Wu <olvaffe at gmail.com>
>> Cc: Gerd Hoffmann <kraxel at redhat.com>
>> Cc: Gustavo Padovan <gustavo.padovan at collabora.com>
>> Cc: Robert Foss <robert.foss at collabora.com>
> 
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
> 
> Side:
> Rob, should we follow-up on 9fdd90c0f and drop the
> virtio_gpu_fence_emit() return type?

Good idea. None of the called functions return anything.
I'll get right on it.


Rob.


More information about the dri-devel mailing list