[PATCH] drm: Fix drm.h uapi header for GNU/kFreeBSD

Daniel Vetter daniel at ffwll.ch
Mon May 6 08:16:21 UTC 2019


On Sat, May 04, 2019 at 09:43:14PM +0100, James Clarke wrote:
> On 15 Jan 2019, at 18:41, Eric Anholt <eric at anholt.net> wrote:
> > 
> > Daniel Vetter <daniel at ffwll.ch> writes:
> > 
> >> On Tue, Jan 15, 2019 at 03:04:18PM +0000, James Clarke wrote:
> >>> Like GNU/Linux, GNU/kFreeBSD's sys/types.h does not define the uintX_t
> >>> types, which differs from the BSDs' headers. Thus we should include
> >>> stdint.h to ensure we have all the required integer types.
> >>> 
> >>> Signed-off-by: James Clarke <jrtc27 at jrtc27.com>
> >> 
> >> Would be good to get an ack from some other *bsd that this is still all
> >> fine. lgtm otherwise.
> >> -Daniel
> > 
> > I think there was some need for inttypes.h instead of stdint like a
> > decade ago when I was working on BSDs, but that was already almost
> > irrelevant then.
> 
> Hi, just following up on this; is there still the need for an ACK?

Yeah and ack without a "decades ago" qualifier would be nice.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list