[PATCH 1/3] drm/virtio: set seqno for dma-fence

Gerd Hoffmann kraxel at redhat.com
Mon May 6 08:53:36 UTC 2019


On Mon, Apr 29, 2019 at 03:08:23PM -0700, Chia-I Wu wrote:
> This is motivated by having meaningful ftrace events, but it also
> fixes use cases where dma_fence_is_later is called, such as in
> sync_file_merge.
> 
> In other drivers, fence creation and cmdbuf submission normally
> happen atomically,
> 
>   mutex_lock();
>   fence = dma_fence_create(..., ++timeline->seqno);
>   submit_cmdbuf();
>   mutex_unlock();
> 
> and have no such issue.  But in our driver, because most ioctls
> queue commands into ctrlq, we do not want to grab a lock.  Instead,
> we set seqno to 0 when a fence is created, and update it when the
> command is finally queued and the seqno is known.

Series pushed to drm-misc-next.

thanks,
  Gerd



More information about the dri-devel mailing list