[PATCH 4/4] drm/amdgpu: stop removing BOs from the LRU during CS

Christian König ckoenig.leichtzumerken at gmail.com
Mon May 13 14:17:34 UTC 2019


Hi Prike,

unfortunately Marek came up with an even better test case, and this 
unfortunately solves only about 80% of all cases where this problem can 
happen.

So Abaqus might work in 4 of 5 runs, but then still fail. I'm currently 
working on trying to fix the remaining 20%.

Give me a day or two to figure things out,
Christian.

Am 13.05.19 um 16:01 schrieb Liang, Prike:
> Hi Christian ,
>
> The series patch can resolve Abaqus pinned failed issue .
> Would you like push the four fix patches to drm-next branch .
>
> Thanks,
> Prike
> -----Original Message-----
> From: Christian König <ckoenig.leichtzumerken at gmail.com>
> Sent: Friday, May 10, 2019 10:13 PM
> To: Olsak, Marek <Marek.Olsak at amd.com>; Zhou, David(ChunMing) <David1.Zhou at amd.com>; Liang, Prike <Prike.Liang at amd.com>; dri-devel at lists.freedesktop.org
> Subject: [PATCH 4/4] drm/amdgpu: stop removing BOs from the LRU during CS
>
> [CAUTION: External Email]
>
> This avoids OOM situations when we have lots of threads submitting at the same time.
>
> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> index a1d6a0721e53..8828d30cd409 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -648,7 +648,7 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p,
>          }
>
>          r = ttm_eu_reserve_buffers(&p->ticket, &p->validated, true,
> -                                  &duplicates, true);
> +                                  &duplicates, false);
>          if (unlikely(r != 0)) {
>                  if (r != -ERESTARTSYS)
>                          DRM_ERROR("ttm_eu_reserve_buffers failed.\n");
> --
> 2.17.1
>



More information about the dri-devel mailing list