[PATCH v5 00/20] Share TTM code among DRM framebuffer drivers
Thomas Zimmermann
tzimmermann at suse.de
Wed May 15 07:05:54 UTC 2019
Hi,
most of this patch set still needs reviews.
If it's too large for merging or reviewing at once, I could move the
driver changes into separate patch sets. The vbox driver's changes have
been accepted by Hans already. So only keeping the core changes plus
vbox would be an option.
Best regards
Thomas
Am 08.05.19 um 10:26 schrieb Thomas Zimmermann:
> Several simple framebuffer drivers copy most of the TTM code from each
> other. The implementation is always the same; except for the name of
> some data structures.
>
> As recently discussed, this patch set provides generic memory-management
> code for simple framebuffers with dedicated video memory. It further
> converts the respective drivers to the generic code. The shared code
> is basically the same implementation as the one copied among individual
> drivers.
>
> The patch set contains two major changes: first, it introduces
> |struct drm_gem_vram_object| and helpers (GEM VRAM). It's a GEM object
> that is backed by VRAM. The type's purpose is somewhat similar to
> |struct drm_gem_{cma, shmem}_object|: it provides an commom implementation
> that handles all the basic cases. Second, the patch set introduces
> |struct drm_vram_mm| and helpers (VRAM MM). It's an implementation of a
> basic memory manager for VRAM.
>
> Both, GEM VRAM and VRAM MM, support buffer placement in VRAM and system
> memory. Both can be used independedly from each other if desired by the
> DRM driver.
>
> Currently ast, bochs, mgag200, vboxvideo and hisilicon/hibmc can use
> these helpers.
>
> Future directions: with these changes, the respective drivers can also
> share some of their mode-setting or fbdev code. GEM VRAM's PRIME helpers
> allow for using the generic fbcon emulation.
>
> The patch set is against a recent drm-tip.
>
> v5:
> * move bochs PRIME functions to GEM VRAM helpers
> * always set struct file_operations.llseek to no_llseek()
> * add WARN_ON_ONCE for pin-count mismatches
> * only allocate 2 entries in placements array
> v4:
> * cleanups from checkpatch.pl
> * add more documentation for VRAM helpers
> * remove several fixed-size types from interfaces
> * don't make drivers depend on DRM_TTM; auto-selected if necessary
> * use single config optiom DRM_VRAM_HELPER
> v3:
> * share VRAM MM callback structure among drivers
> * move VRAM MM instances to drm_device and share rsp. code
> v2:
> * rename |struct drm_gem_ttm_object| to |struct drm_gem_vram_object|
> * rename |struct drm_simple_ttm| to |struct drm_vram_mm|
> * make drm_is_gem_ttm() an internal helper
> * add drm_gem_vram_kmap_at()
> * return is_iomem from kmap functions
> * redefine TTM placement flags for public interface
> * add drm_vram_mm_mmap() helper
> * replace almost all of driver's TTM code with these helpers
> * documentation fixes
>
> Thomas Zimmermann (20):
> drm: Add |struct drm_gem_vram_object| and helpers
> drm: Add |struct drm_gem_vram_object| callbacks for |struct
> ttm_bo_driver|
> drm: Add |struct drm_gem_vram_object| callbacks for |struct
> drm_driver|
> drm: Add drm_gem_vram_fill_create_dumb() to create dumb buffers
> drm: Add simple PRIME helpers for GEM VRAM
> drm: Add VRAM MM, a simple memory manager for dedicated VRAM
> drm: Add default instance for VRAM MM callback functions
> drm: Integrate VRAM MM into struct drm_device
> drm/ast: Convert AST driver to |struct drm_gem_vram_object|
> drm/ast: Convert AST driver to VRAM MM
> drm/ast: Replace mapping code with drm_gem_vram_{kmap/kunmap}()
> drm/bochs: Convert bochs driver to |struct drm_gem_vram_object|
> drm/bochs: Convert bochs driver to VRAM MM
> drm/mgag200: Convert mgag200 driver to |struct drm_gem_vram_object|
> drm/mgag200: Convert mgag200 driver to VRAM MM
> drm/mgag200: Replace mapping code with drm_gem_vram_{kmap/kunmap}()
> drm/vboxvideo: Convert vboxvideo driver to |struct
> drm_gem_vram_object|
> drm/vboxvideo: Convert vboxvideo driver to VRAM MM
> drm/hisilicon: Convert hibmc-drm driver to |struct
> drm_gem_vram_object|
> drm/hisilicon: Convert hibmc-drm driver to VRAM MM
>
> Documentation/gpu/drm-mm.rst | 34 +-
> drivers/gpu/drm/Kconfig | 7 +
> drivers/gpu/drm/Makefile | 5 +
> drivers/gpu/drm/ast/Kconfig | 3 +-
> drivers/gpu/drm/ast/ast_drv.c | 13 +-
> drivers/gpu/drm/ast/ast_drv.h | 71 +-
> drivers/gpu/drm/ast/ast_fb.c | 34 +-
> drivers/gpu/drm/ast/ast_main.c | 77 +-
> drivers/gpu/drm/ast/ast_mode.c | 124 +--
> drivers/gpu/drm/ast/ast_ttm.c | 302 +-------
> drivers/gpu/drm/bochs/Kconfig | 2 +-
> drivers/gpu/drm/bochs/bochs.h | 54 +-
> drivers/gpu/drm/bochs/bochs_drv.c | 22 +-
> drivers/gpu/drm/bochs/bochs_kms.c | 18 +-
> drivers/gpu/drm/bochs/bochs_mm.c | 426 +----------
> drivers/gpu/drm/drm_gem_vram_helper.c | 713 ++++++++++++++++++
> drivers/gpu/drm/drm_vram_helper_common.c | 98 +++
> drivers/gpu/drm/drm_vram_mm_helper.c | 295 ++++++++
> drivers/gpu/drm/hisilicon/hibmc/Kconfig | 2 +-
> .../gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 21 +-
> .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 14 +-
> .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 33 +-
> .../gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 30 +-
> drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c | 341 +--------
> drivers/gpu/drm/mgag200/Kconfig | 2 +-
> drivers/gpu/drm/mgag200/mgag200_cursor.c | 88 ++-
> drivers/gpu/drm/mgag200/mgag200_drv.c | 13 +-
> drivers/gpu/drm/mgag200/mgag200_drv.h | 74 +-
> drivers/gpu/drm/mgag200/mgag200_fb.c | 34 +-
> drivers/gpu/drm/mgag200/mgag200_main.c | 87 +--
> drivers/gpu/drm/mgag200/mgag200_mode.c | 53 +-
> drivers/gpu/drm/mgag200/mgag200_ttm.c | 301 +-------
> drivers/gpu/drm/vboxvideo/Kconfig | 2 +-
> drivers/gpu/drm/vboxvideo/vbox_drv.c | 12 +-
> drivers/gpu/drm/vboxvideo/vbox_drv.h | 75 +-
> drivers/gpu/drm/vboxvideo/vbox_fb.c | 22 +-
> drivers/gpu/drm/vboxvideo/vbox_main.c | 75 +-
> drivers/gpu/drm/vboxvideo/vbox_mode.c | 36 +-
> drivers/gpu/drm/vboxvideo/vbox_ttm.c | 355 +--------
> include/drm/drm_device.h | 4 +
> include/drm/drm_gem_vram_helper.h | 160 ++++
> include/drm/drm_vram_mm_helper.h | 102 +++
> 42 files changed, 1797 insertions(+), 2437 deletions(-)
> create mode 100644 drivers/gpu/drm/drm_gem_vram_helper.c
> create mode 100644 drivers/gpu/drm/drm_vram_helper_common.c
> create mode 100644 drivers/gpu/drm/drm_vram_mm_helper.c
> create mode 100644 include/drm/drm_gem_vram_helper.h
> create mode 100644 include/drm/drm_vram_mm_helper.h
>
> --
> 2.21.0
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20190515/d0e924b3/attachment.sig>
More information about the dri-devel
mailing list