[PATCH 2/5] drm/vmgfx: kill off unused init_mutex
Thomas Hellstrom
thellstrom at vmware.com
Thu May 23 06:48:09 UTC 2019
On Wed, 2019-05-22 at 17:41 +0100, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
>
> According to the docs - prevents firstopen/lastclose races. Yet never
> used in practise.
>
> Cc: "VMware Graphics" <linux-graphics-maintainer at vmware.com>
> Cc: Thomas Hellstrom <thellstrom at vmware.com>
> Cc: Daniel Vetter <daniel at ffwll.ch>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Thomas Hellstrom <thellstrom at vmware.com>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 1 -
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 5 -----
> 2 files changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> index a38f06909fb6..d3f108f7e52d 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> @@ -664,7 +664,6 @@ static int vmw_driver_load(struct drm_device
> *dev, unsigned long chipset)
> INIT_LIST_HEAD(&dev_priv->res_lru[i]);
> }
>
> - mutex_init(&dev_priv->init_mutex);
> init_waitqueue_head(&dev_priv->fence_queue);
> init_waitqueue_head(&dev_priv->fifo_queue);
> dev_priv->fence_queue_waiters = 0;
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
> b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
> index 96983c47fb40..9be2176cc260 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
> @@ -484,11 +484,6 @@ struct vmw_private {
>
> spinlock_t resource_lock;
> struct idr res_idr[vmw_res_max];
> - /*
> - * Block lastclose from racing with firstopen.
> - */
> -
> - struct mutex init_mutex;
>
> /*
> * A resource manager for kernel-only surfaces and
More information about the dri-devel
mailing list