[PATCH 1/2] drm/msm/dpu: Use provided drm_minor to initialize debugfs

Rob Clark robdclark at gmail.com
Fri May 24 22:32:15 UTC 2019


On Fri, May 24, 2019 at 1:43 PM Stephen Boyd <swboyd at chromium.org> wrote:
>
> Quoting Sean Paul (2019-05-24 10:32:18)
> > From: Sean Paul <seanpaul at chromium.org>
> >
> > Instead of reaching into dev->primary for debugfs_root, use the minor
> > passed into debugfs_init.
> >
> > This avoids creating the debug directory under /sys/kernel/debug/ and
> > instead creates the directory under the correct node in
> > /sys/kernel/debug/dri/<node>/
>
> So does this make it become /sys/kernel/debug/dri/<node>/debug?
>
> I wonder why it can't all be created under /sys/kernel/debug/dri/<node>
> and then avoid the extra "debug" directory that isn't adding any value?
>

>From the looks of it, it will still create the 'debug' dir, but at
least under the correct <node>..

for the record, I'm all for getting rid of the extra 'debug'
directory, it saves me some extra typing ;-)

BR,
-R


More information about the dri-devel mailing list