[PATCH] drm/mcde: Fix an uninitialized variable

Dan Carpenter dan.carpenter at oracle.com
Wed May 29 11:34:58 UTC 2019


We never set "vblank" to "false".

Current versions of GCC will initialize it to zero automatically at
certain optimization levels so that's probably why this didn't show up
in testing.

Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
---
 drivers/gpu/drm/mcde/mcde_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/mcde/mcde_display.c b/drivers/gpu/drm/mcde/mcde_display.c
index f3ef108a41d9..751454ae3cd1 100644
--- a/drivers/gpu/drm/mcde/mcde_display.c
+++ b/drivers/gpu/drm/mcde/mcde_display.c
@@ -65,7 +65,7 @@ enum mcde_dsi_formatter {
 void mcde_display_irq(struct mcde *mcde)
 {
 	u32 mispp, misovl, mischnl;
-	bool vblank;
+	bool vblank = false;
 
 	/* Handle display IRQs */
 	mispp = readl(mcde->regs + MCDE_MISPP);
-- 
2.20.1



More information about the dri-devel mailing list