[PATCH v14 1/5] dma-buf: Add dma-buf heaps framework

John Stultz john.stultz at linaro.org
Mon Nov 4 18:44:15 UTC 2019


On Mon, Nov 4, 2019 at 2:24 AM Brian Starkey <Brian.Starkey at arm.com> wrote:
> On Fri, Nov 01, 2019 at 09:42:34PM +0000, John Stultz wrote:
> > From: "Andrew F. Davis" <afd at ti.com>
> >
> > Additionally should the interface grow in the future, we have a
> > DMA_HEAP_IOC_GET_FEATURES ioctl which can return future feature
> > flags.
>
> The userspace patch doesn't use this - and there's no indication of
> what it's intended to allow in the future. I missed the discussion
> about it, do you have a link?

Yea. Sorry, It was feedback I got via IRC. If your curious the irc log
can be found here:
  https://people.freedesktop.org/~cbrill/dri-log/?channel=dri-devel&highlight_names=&date=2019-10-30&show_html=true

> The new zeroing stuff all looks good to me - so wrt. that you can add
> back my r-b; would still like to get some clarification on the
> get_features, though.

>From Daniel's feedback it sounds like I'll drop the empty get_features
ioctl then.

> Couple of typos below.

Apologies for my bad spelling! Thanks for the continued attention and review!
-john


More information about the dri-devel mailing list