[PATCH 6/9] drm/ast: Add primary plane

[Thomas Zimmermann]

Hi

Am 05.11.19 um 10:51 schrieb Gerd Hoffmann:
>> +static const struct drm_plane_funcs ast_primary_plane_funcs = {
>> +	.update_plane = drm_atomic_helper_update_plane,
>> +	.disable_plane = drm_atomic_helper_disable_plane,
>> +	.destroy = drm_plane_cleanup,
>> +	.reset = drm_atomic_helper_plane_reset,
>> +	.set_property = NULL,
>> +	.atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state,
>> +	.atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
>> +	.atomic_set_property = NULL,
>> +	.atomic_get_property = NULL,
> 
> It's not needed to explicitly set optional function pointers to NULL.

Sure. These NULL assignments helped me with keeping track of the work
during the conversion. I forgot to remove them here and in the other patch.

Best regards
Thomas

> 
>>  static const struct drm_encoder_helper_funcs ast_enc_helper_funcs = {
>>  	.dpms = ast_encoder_dpms,
>>  	.prepare = ast_encoder_prepare,
>> @@ -976,10 +1045,33 @@ static void ast_cursor_fini(struct drm_device *dev)
>>  
>>  int ast_mode_init(struct drm_device *dev)
>>  {
>> +	static const uint32_t primary_plane_formats[] = {
>> +		DRM_FORMAT_XRGB8888,
>> +		DRM_FORMAT_RGB565,
>> +		DRM_FORMAT_C8,
>> +	};
> 
> I'd suggest to move this out of the function.
> 
> cheers,
>   Gerd
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20191106/c0170f3f/attachment.sig>