[Bug 205393] [amdgpu powerplay] vega10: custom pp_table, AVFS accidentally reenabled after display powersave

[bugzilla-daemon at bugzilla.kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=205393

--- Comment #5 from Alex Deucher (alexdeucher at gmail.com) ---
(In reply to haro41 from comment #4)
> Yes, your patch works and has the same effect, apparently.
> 
> What confused me and the reason why i prefered to leave the
> vega10_update_avfs() call before the flag modification, was the code inside
> vega10_update_avfs():
> 
> static int vega10_update_avfs(struct pp_hwmgr *hwmgr)
> {
>       struct vega10_hwmgr *data = hwmgr->backend;
> 
>       if (data->need_update_dpm_table & DPMTABLE_OD_UPDATE_VDDC) {
>               vega10_avfs_enable(hwmgr, false);
>       } else if (data->need_update_dpm_table) {
>               vega10_avfs_enable(hwmgr, false);
>               vega10_avfs_enable(hwmgr, true);
>       } else {
>               vega10_avfs_enable(hwmgr, true);
>       }
> 
>       return 0;
> }
> 
> Here is a disable/enable sequence inserted, perhaps for a reason?

It's needed to disable the current AFVS settings before reapplying the new
ones.  That shouldn't be necessary with the DPMTABLE_OD_UPDATE_VDDC flag set
because in that case, we just disable AVFS.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.