[PATCH] drm/omap: Migrate minimum FCK/PCK ratio from Kconfig to dts

Tero Kristo t-kristo at ti.com
Tue Oct 1 08:12:10 UTC 2019


On 01/10/2019 08:07, Tomi Valkeinen wrote:
> On 30/09/2019 20:48, Tero Kristo wrote:
> 
>> Hmmh, after some testing, it seems there is bad stuff happening with 
>> the divider clock implementation, I am re-working it as of now. 
>> Basically what is wrong is that with a divider max value of say 16, 
>> the driver attempts to craft the max value into a mask, but this ends 
>> up being 0x1f. If the max value is 15, it ends up into 0xf which is 
>> correct.
> 
> Ok, that explains the max not working.
> 
> It doesn't explain the other issue, where the TRM says the max div is 
> 32, but it does not work. But taking the max div from the old SoCs, 16, 
> is not correct either, as it seems that dividers up to 31 work ok.
> 
>   Tomi
> 

Ok, attached a series that hopefully fixes it, any testing feedback 
welcome before I post this properly.

This also supports omap36xx dpll4_m4_ck divider up-to 31, other omap3 
family is limited to 16.

-Tero


--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-clk-ti-divider-cleanup-ti_clk_parse_divider_data-API.patch
Type: text/x-patch
Size: 3104 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20191001/80f3bf3e/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-clk-ti-divider-convert-to-use-min-max-mask-instead-o.patch
Type: text/x-patch
Size: 8401 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20191001/80f3bf3e/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-ARM-dts-omap3-fix-DPLL4-M4-divider-max-value.patch
Type: text/x-patch
Size: 1542 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20191001/80f3bf3e/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-clk-ti-divider-cleanup-_register_divider-and-ti_clk_.patch
Type: text/x-patch
Size: 6838 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20191001/80f3bf3e/attachment-0007.bin>


More information about the dri-devel mailing list