[PATCH] drm/amdgpu/display: make various arrays static, makes object smaller

Harry Wentland hwentlan at amd.com
Tue Oct 8 14:20:27 UTC 2019


On 2019-10-08 10:00 a.m., Joe Perches wrote:
> On Tue, 2019-10-08 at 13:56 +0000, Harry Wentland wrote:
> []
>>> diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c
>> []
>>> @@ -2745,7 +2745,7 @@ static enum bp_result bios_get_board_layout_info(
>>>  	struct bios_parser *bp;
>>>  	enum bp_result record_result;
>>>  
>>> -	const unsigned int slot_index_to_vbios_id[MAX_BOARD_SLOTS] = {
>>> +	static const unsigned int slot_index_to_vbios_id[MAX_BOARD_SLOTS] = {
>>
>> Won't this break the multi-GPU case where you'll have multiple driver
>> instances with different layout?
> 
> As the array is read-only, how could that happen?
> 

You're right.

Patch is
Reviewed-by: Harry Wentland <harry.wentland at amd.com>

Harry

> 


More information about the dri-devel mailing list