[PATCH v2 13/50] drm/bridge: panel: Implement bridge connector operations

Sam Ravnborg sam at ravnborg.org
Wed Oct 9 19:24:47 UTC 2019


Hi Tomi

On Thu, Oct 03, 2019 at 08:56:15AM +0300, Tomi Valkeinen wrote:
> Hi Sam,
> 
> On 20/08/2019 13:37, Sam Ravnborg wrote:
> 
> > > @@ -123,6 +123,18 @@ static void panel_bridge_post_disable(struct drm_bridge *bridge)
> > >   	drm_panel_unprepare(panel_bridge->panel);
> > >   }
> > > +static int panel_bridge_get_modes(struct drm_bridge *bridge,
> > > +				  struct drm_connector *connector)
> > > +{
> > > +	struct panel_bridge *panel_bridge = drm_bridge_to_panel_bridge(bridge);
> > > +
> > > +	/*
> > > +	 * FIXME: drm_panel_get_modes() should take the connector as an
> > > +	 * argument.
> > > +	 */
> > Noted, I have patches to fix this. Needs a little testing/polishing
> > before I post them.
> 
> Do you have any testable patches for this?
> 
> I was testing this series with a Toshiba DPI-2-DSI bridge and a DSI panel,
> and was hitting a crash as simple-panel couldn't get the connector.


If time permits I will refresh the patches this weekend and send them
out.
But right now cannot promise much as I am awful behind.

	Sam


More information about the dri-devel mailing list