[PATCH] drm/msm/mdp5: Remove set but not used variable 'hw_cfg' in modeset_init
Bjorn Andersson
bjorn.andersson at linaro.org
Thu Oct 10 04:00:08 UTC 2019
On Wed 09 Oct 07:13 PDT 2019, zhengbin wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c: In function modeset_init:
> drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c:458:28: warning: variable hw_cfg set but not used [-Wunused-but-set-variable]
>
> It is not used since commit 36d1364abbed ("drm/msm/mdp5:
> Clean up interface assignment")
>
> Reported-by: Hulk Robot <hulkci at huawei.com>
> Signed-off-by: zhengbin <zhengbin13 at huawei.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson at linaro.org>
> ---
> drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
> index f8bd0bf..5476892 100644
> --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
> +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
> @@ -461,14 +461,11 @@ static int modeset_init(struct mdp5_kms *mdp5_kms)
> {
> struct drm_device *dev = mdp5_kms->dev;
> struct msm_drm_private *priv = dev->dev_private;
> - const struct mdp5_cfg_hw *hw_cfg;
> unsigned int num_crtcs;
> int i, ret, pi = 0, ci = 0;
> struct drm_plane *primary[MAX_BASES] = { NULL };
> struct drm_plane *cursor[MAX_BASES] = { NULL };
>
> - hw_cfg = mdp5_cfg_get_hw_config(mdp5_kms->cfg);
> -
> /*
> * Construct encoders and modeset initialize connector devices
> * for each external display interface.
> --
> 2.7.4
>
More information about the dri-devel
mailing list