[PATCH 3/4] media: radio: wl1273: fix interrupt masking on release

Johan Hovold johan at kernel.org
Thu Oct 10 13:13:32 UTC 2019

If a process is interrupted while accessing the radio device and the
core lock is contended, release() could return early and fail to update
the interrupt mask.

Note that the return value of the v4l2 release file operation is

Fixes: 87d1a50ce451 ("[media] V4L2: WL1273 FM Radio: TI WL1273 FM radio driver")
Cc: stable <stable at vger.kernel.org>     # 2.6.38
Cc: Matti Aaltonen <matti.j.aaltonen at nokia.com>
Cc: Mauro Carvalho Chehab <mchehab at redhat.com>
Signed-off-by: Johan Hovold <johan at kernel.org>
 drivers/media/radio/radio-wl1273.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/radio/radio-wl1273.c b/drivers/media/radio/radio-wl1273.c
index 104ac41c6f96..112376873167 100644
--- a/drivers/media/radio/radio-wl1273.c
+++ b/drivers/media/radio/radio-wl1273.c
@@ -1148,8 +1148,7 @@ static int wl1273_fm_fops_release(struct file *file)
 	if (radio->rds_users > 0) {
 		if (radio->rds_users == 0) {
-			if (mutex_lock_interruptible(&core->lock))
-				return -EINTR;
+			mutex_lock(&core->lock);
 			radio->irq_flags &= ~WL1273_RDS_EVENT;

More information about the dri-devel mailing list