[PATCH] dma-buf/resv: fix exclusive fence get

Qiang Yu yuq825 at gmail.com
Thu Oct 10 14:27:59 UTC 2019


Hi Chris,

This fix has been pushed to drm-misc-next for a while. But Linux
5.4-rc kernels still does not have this fix.
Should it be also pushed to drm-misc-fixes?

Thanks,
Qiang


On Sun, Sep 22, 2019 at 8:50 PM Chris Wilson <chris at chris-wilson.co.uk> wrote:
>
> Quoting Chris Wilson (2019-09-22 13:17:19)
> > Quoting Qiang Yu (2019-09-22 08:49:00)
> > > This causes kernel crash when testing lima driver.
> > >
> > > Cc: Christian K├Ânig <christian.koenig at amd.com>
> > > Fixes: b8c036dfc66f ("dma-buf: simplify reservation_object_get_fences_rcu a bit")
> > > Signed-off-by: Qiang Yu <yuq825 at gmail.com>
> > > ---
> > >  drivers/dma-buf/dma-resv.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c
> > > index 42a8f3f11681..709002515550 100644
> > > --- a/drivers/dma-buf/dma-resv.c
> > > +++ b/drivers/dma-buf/dma-resv.c
> > > @@ -471,7 +471,7 @@ int dma_resv_get_fences_rcu(struct dma_resv *obj,
> > >         if (pfence_excl)
> > >                 *pfence_excl = fence_excl;
> > >         else if (fence_excl)
> > > -               shared[++shared_count] = fence_excl;
> > > +               shared[shared_count++] = fence_excl;
> >
> > Oops.
> >
> > Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
>
> Applied, thanks for the fix.
> -Chris


More information about the dri-devel mailing list