[PATCH] drm/i915: Don't disable interrupts independently of the lock
Sebastian Andrzej Siewior
bigeasy at linutronix.de
Thu Oct 10 16:06:40 UTC 2019
The locks (active.lock and rq->lock) need to be taken with disabled
interrupts. This is done in i915_request_retire() by disabling the
interrupts independently of the locks itself.
While local_irq_disable()+spin_lock() equals spin_lock_irq() on vanilla
it does not on PREEMPT_RT. Also, it is not obvious if there is a special reason
to why the interrupts are disabled independently of the lock.
Enable/disable interrupts as part of the locking instruction.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy at linutronix.de>
drivers/gpu/drm/i915/i915_request.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
@@ -251,15 +251,13 @@ static bool i915_request_retire(struct i
* We only loosely track inflight requests across preemption,
* and so we may find ourselves attempting to retire a _completed_
* request that we have removed from the HW and put back on a run
@@ -278,9 +276,7 @@ static bool i915_request_retire(struct i
More information about the dri-devel