[PATCH 0/4] treewide: fix interrupted release
johan at kernel.org
Fri Oct 11 09:36:33 UTC 2019
On Thu, Oct 10, 2019 at 03:50:43PM +0200, Daniel Vetter wrote:
> On Thu, Oct 10, 2019 at 03:13:29PM +0200, Johan Hovold wrote:
> > Two old USB drivers had a bug in them which could lead to memory leaks
> > if an interrupted process raced with a disconnect event.
> > Turns out we had a few more driver in other subsystems with the same
> > kind of bug in them.
> Random funny idea: Could we do some debug annotations (akin to
> might_sleep) that splats when you might_sleep_interruptible somewhere
> where interruptible sleeps are generally a bad idea? Like in
There's nothing wrong with interruptible sleep in fops->release per se,
it's just that drivers cannot return -ERESTARTSYS and friends and expect
to be called again later.
The return value from release() is ignored by vfs, and adding a splat in
__fput() to catch these buggy drivers might be overkill.
More information about the dri-devel