[PATCH 3/3] drm/atmel-hlcdc: Use swap() where appropriate

[Ville Syrjälä]

On Thu, Oct 10, 2019 at 03:24:28PM +0200, Boris Brezillon wrote:
> On Thu, 10 Oct 2019 16:11:59 +0300
> Ville Syrjala <ville.syrjala at linux.intel.com> wrote:
> 
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > @swap@
> > identifier TEMP;
> > expression A,B;
> > @@
> > - TEMP = A;
> > - A = B;
> > - B = TEMP;
> > + swap(A, B);
> > 
> > @@
> > type T;
> > identifier swap.TEMP;
> > @@
> > (
> > - T TEMP;
> > |
> > - T TEMP = {...};
> > )
> > ... when != TEMP
> > 
> > Cc: Sam Ravnborg <sam at ravnborg.org>
> > Cc: Boris Brezillon <bbrezillon at kernel.org>
> > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Reviewed-by: Boris Brezillon <boris.brezillon at collabora.com>

Ta. Pushed to drm-misc-next.

> 
> > ---
> >  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > index 89f5a756fa37..034f202dfe8f 100644
> > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > @@ -601,7 +601,6 @@ static int atmel_hlcdc_plane_atomic_check(struct drm_plane *p,
> >  	struct drm_framebuffer *fb = state->base.fb;
> >  	const struct drm_display_mode *mode;
> >  	struct drm_crtc_state *crtc_state;
> > -	unsigned int tmp;
> >  	int ret;
> >  	int i;
> >  
> > @@ -694,9 +693,7 @@ static int atmel_hlcdc_plane_atomic_check(struct drm_plane *p,
> >  	 * Swap width and size in case of 90 or 270 degrees rotation
> >  	 */
> >  	if (drm_rotation_90_or_270(state->base.rotation)) {
> > -		tmp = state->src_w;
> > -		state->src_w = state->src_h;
> > -		state->src_h = tmp;
> > +		swap(state->src_w, state->src_h);
> >  	}
> >  
> >  	if (!desc->layout.size &&

-- 
Ville Syrjälä
Intel