[PATCHv8 1/2] drm: tda998x: use cec_notifier_conn_(un)register
darekm at google.com
Thu Oct 17 09:27:46 UTC 2019
On Wed, Oct 16, 2019 at 6:14 PM Russell King - ARM Linux admin
<linux at armlinux.org.uk> wrote:
> On Wed, Oct 16, 2019 at 03:39:15PM +0200, Hans Verkuil wrote:
> > From: Dariusz Marcinkiewicz <darekm at google.com>
> > Use the new cec_notifier_conn_(un)register() functions to
> > (un)register the notifier for the HDMI connector.
> > Signed-off-by: Dariusz Marcinkiewicz <darekm at google.com>
> > Signed-off-by: Hans Verkuil <hverkuil-cisco at xs4all.nl>
> Please explain in detail what this mutex actually achieves.
> So, all in all, I don't see what this lock is doing, and I think it
> should be removed.
> If it's necessary for a future change (which may or may not be merged)
> then the lock should be part of that future change, because the change
> proposed by this patch certainly does not need it.
Yes, with the change being split into 2 patches like that, the mutex
is not needed here.
More information about the dri-devel