[PATCH] gpu: host1x: make 'host1x_cdma_wait_pushbuffer_space' static

Ben Dooks (Codethink) ben.dooks at codethink.co.uk
Thu Oct 17 11:04:27 UTC 2019


The host1x_cdma_wait_pushbuffer_space function is not declared
or directly called from outside the file it is in, so make it
static.

Fixes the following sparse warnign:
drivers/gpu/host1x/cdma.c:235:5: warning: symbol 'host1x_cdma_wait_pushbuffer_space' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks at codethink.co.uk>
---
Cc: Thierry Reding <thierry.reding at gmail.com>
Cc: dri-devel at lists.freedesktop.org
Cc: linux-tegra at vger.kernel.org
---
 drivers/gpu/host1x/cdma.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/host1x/cdma.c b/drivers/gpu/host1x/cdma.c
index 48c84c48299c..e8d3fda91d8a 100644
--- a/drivers/gpu/host1x/cdma.c
+++ b/drivers/gpu/host1x/cdma.c
@@ -232,9 +232,9 @@ unsigned int host1x_cdma_wait_locked(struct host1x_cdma *cdma,
  *
  * Must be called with the cdma lock held.
  */
-int host1x_cdma_wait_pushbuffer_space(struct host1x *host1x,
-				      struct host1x_cdma *cdma,
-				      unsigned int needed)
+static int host1x_cdma_wait_pushbuffer_space(struct host1x *host1x,
+					     struct host1x_cdma *cdma,
+					     unsigned int needed)
 {
 	while (true) {
 		struct push_buffer *pb = &cdma->push_buffer;
-- 
2.23.0



More information about the dri-devel mailing list