[PATCH] drm/armada: make armada_overlay_duplicate_state static

Ben Dooks (Codethink) ben.dooks at codethink.co.uk
Thu Oct 17 11:12:39 UTC 2019

The armada_overlay_duplicate_state is not declared outside
the unit, so make it static to avoid the following sparse

drivers/gpu/drm/armada/armada_overlay.c:328:24: warning: symbol 'armada_overlay_duplicate_state' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks at codethink.co.uk>
Cc: Russell King <linux at armlinux.org.uk>
Cc: David Airlie <airlied at linux.ie>
Cc: Daniel Vetter <daniel at ffwll.ch>
Cc: dri-devel at lists.freedesktop.org
 drivers/gpu/drm/armada/armada_overlay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/armada/armada_overlay.c b/drivers/gpu/drm/armada/armada_overlay.c
index 07f0da4d9ba1..b3e942121fd7 100644
--- a/drivers/gpu/drm/armada/armada_overlay.c
+++ b/drivers/gpu/drm/armada/armada_overlay.c
@@ -325,7 +325,7 @@ static void armada_overlay_reset(struct drm_plane *plane)
-struct drm_plane_state *
+static struct drm_plane_state *
 armada_overlay_duplicate_state(struct drm_plane *plane)
 	struct armada_overlay_state *state;

More information about the dri-devel mailing list