[PATCH v3 00/13] drm/dp: Move drm_dp_link helpers to Tegra DRM

Thierry Reding thierry.reding at gmail.com
Mon Oct 21 14:34:24 UTC 2019

From: Thierry Reding <treding at nvidia.com>


Following up on the discussion about the usefulness of the drm_dp_link
helpers, here's a new series that adds a couple of new DPCD parser
functions and then pushes the drm_dp_link helpers down into drivers.
For most drivers this was pretty easy to do since they didn't heavily
rely on the struct drm_dp_link. I decided to move the drm_dp_link
helpers to the Tegra driver because they are more heavily used there
and I have a subsequent series that adds support for DisplayPort on
various Tegra boards based on those helpers.

The plan is to merge this series into drm-misc once reviewed so that I
can rebase my Tegra DP support patches on that, hopefully in time for

I don't have access to the bridges, Rockchip or MSM hardware, so those
drivers are only build-tested. Since this series really only replaces
variables, I don't think there's a high risk of breaking anything.

Changes in v3:
- drop drm_dp_aux_rd_interval() helper patch; this turned out to be
  incomplete and fixing it made it useless over existing helpers
- add Reviewed-by from Lyude
- address review comments


Thierry Reding (13):
  drm/dp: Sort includes alphabetically
  drm/dp: Remove a gratuituous blank line
  drm/dp: Add drm_dp_fast_training_cap() helper
  drm/dp: Add drm_dp_channel_coding_supported() helper
  drm/dp: Add drm_dp_alternate_scrambler_reset_cap() helper
  drm/dp: Do not busy-loop during link training
  drm/dp: Add helper to get post-cursor adjustments
  drm/bridge: analogix-anx78xx: Avoid drm_dp_link helpers
  drm/bridge: tc358767: Avoid drm_dp_link helpers
  drm/bridge: tc358767: Use DP nomenclature
  drm/msm: edp: Avoid drm_dp_link helpers
  drm/rockchip: Avoid drm_dp_link helpers
  drm/tegra: Move drm_dp_link helpers to Tegra DRM

 drivers/gpu/drm/bridge/analogix-anx78xx.c |  57 ++++++--
 drivers/gpu/drm/bridge/tc358767.c         |  65 ++++++---
 drivers/gpu/drm/drm_dp_helper.c           | 169 ++++------------------
 drivers/gpu/drm/msm/edp/edp_ctrl.c        |  70 ++++++---
 drivers/gpu/drm/rockchip/cdn-dp-core.c    |  12 +-
 drivers/gpu/drm/rockchip/cdn-dp-core.h    |   3 +-
 drivers/gpu/drm/rockchip/cdn-dp-reg.c     |  19 ++-
 drivers/gpu/drm/tegra/Makefile            |   1 +
 drivers/gpu/drm/tegra/dp.c                | 133 +++++++++++++++++
 drivers/gpu/drm/tegra/dp.h                |  26 ++++
 drivers/gpu/drm/tegra/dpaux.c             |   1 +
 drivers/gpu/drm/tegra/sor.c               |   1 +
 include/drm/drm_dp_helper.h               |  51 ++++---
 13 files changed, 373 insertions(+), 235 deletions(-)
 create mode 100644 drivers/gpu/drm/tegra/dp.c
 create mode 100644 drivers/gpu/drm/tegra/dp.h


More information about the dri-devel mailing list