[PATCH v2 04/21] drm/exynos: Fix potential unbalanced calls to pm_runtime_put

Boris Brezillon boris.brezillon at collabora.com
Tue Oct 22 09:14:33 UTC 2019


On Sat, 12 Oct 2019 09:15:26 +0200
Sam Ravnborg <sam at ravnborg.org> wrote:

> Hi Boris/Andrzej.
> 
> >   
> > > 
> > >   
> > > > Note that -ENOSYS is actually a valid case, it just
> > > > means the panel driver does not implement the hook.    
> > > 
> > > 
> > > It would be good then to fix it in panel framework, ie without hook
> > > drm_panel_* function should return 0, ENOSYS makes no sense here.  
> > 
> > I'm fine with that. Thierry, Sam, any opinion?  
> 
> Agreed, I have following patch in my panel patch queue:
> 
> drm/drm_panel: no error when no callback
> 
>     The callbacks in drm_panel_funcs are optional, so do not
>     return an error just because no callback is assigned.
> 
>     Signed-off-by: Sam Ravnborg <sam at ravnborg.org>
> 
> If I get time this weekend I will rebase/test and send the
> set of patches out.

Any progress on that? Can I rebase/send it for you if you don't have
time?


More information about the dri-devel mailing list