drm/mcde: Reconsider duplicate statement in mcde_probe()

Markus Elfring Markus.Elfring at web.de
Mon Oct 28 17:00:04 UTC 2019


Hello,

I have taken another look also at the implementation of the function “mcde_probe”.
Now I wonder why the statement “drm->dev_private = mcde;” was specified twice there.
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/gpu/drm/mcde/mcde_drv.c#L339
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/mcde/mcde_drv.c?id=0365fb6baeb1ebefbbdad9e3f48bab9b3ccb8df3#n339

How do you think about to delete one of them so that a duplicate assignment
can be avoided?

Regards,
Markus


More information about the dri-devel mailing list