[PATCH] drm: amd: amdgpu: Remove NULL check not needed before freeing functions

Wang, Kevin(Yang) Kevin1.Wang at amd.com
Tue Oct 29 09:33:14 UTC 2019

Hi Saurav,

the driver already has the same fix patch,
you can pull the latest driver tree and check it again,

>From 2032324682c1ca563e33c56e51d9ae17a2b38105 Mon Sep 17 00:00:00 2001
From: zhong jiang <zhongjiang at huawei.com>
Date: Tue, 3 Sep 2019 14:15:05 +0800
Subject: [PATCH] drm/amdgpu: remove the redundant null checks

debugfs_remove and kfree has taken the null check in account.
hence it is unnecessary to check it. Just remove the condition.
No functional change.

This issue was detected by using the Coccinelle software.

Signed-off-by: zhong jiang <zhongjiang at huawei.com>
Signed-off-by: Alex Deucher <alexander.deucher at amd.com>

Best Regards,
From: Saurav Girepunje <saurav.girepunje at gmail.com>
Sent: Tuesday, October 29, 2019 5:19 PM
To: Deucher, Alexander <Alexander.Deucher at amd.com>; Koenig, Christian <Christian.Koenig at amd.com>; Zhou, David(ChunMing) <David1.Zhou at amd.com>; airlied at linux.ie <airlied at linux.ie>; daniel at ffwll.ch <daniel at ffwll.ch>; StDenis, Tom <Tom.StDenis at amd.com>; xywang.sjtu at sjtu.edu.cn <xywang.sjtu at sjtu.edu.cn>; Xiao, Jack <Jack.Xiao at amd.com>; sam at ravnborg.org <sam at ravnborg.org>; Wang, Kevin(Yang) <Kevin1.Wang at amd.com>; saurav.girepunje at gmail.com <saurav.girepunje at gmail.com>; amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>; dri-devel at lists.freedesktop.org <dri-devel at lists.freedesktop.org>; linux-kernel at vger.kernel.org <linux-kernel at vger.kernel.org>
Cc: saurav.girepunje at hotmail.com <saurav.girepunje at hotmail.com>
Subject: [PATCH] drm: amd: amdgpu: Remove NULL check not needed before freeing functions

Remove unneeded NULL check before freeing functions
kfree and debugfs_remove.

Signed-off-by: Saurav Girepunje <saurav.girepunje at gmail.com>
 drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
index 5652cc72ed3a..cb94627fc0f4 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
@@ -1077,8 +1077,7 @@ static int amdgpu_debugfs_ib_preempt(void *data, u64 val)

         ttm_bo_unlock_delayed_workqueue(&adev->mman.bdev, resched);

-       if (fences)
-               kfree(fences);
+       kfree(fences);

         return 0;
@@ -1103,8 +1102,7 @@ int amdgpu_debugfs_init(struct amdgpu_device *adev)

 void amdgpu_debugfs_preempt_cleanup(struct amdgpu_device *adev)
-       if (adev->debugfs_preempt)
-               debugfs_remove(adev->debugfs_preempt);
+       debugfs_remove(adev->debugfs_preempt);


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20191029/a6b4d24f/attachment.html>

More information about the dri-devel mailing list