[PATCH] dma-buf: Fix a warning message in dma_heap_buffer_destroy()

Dan Carpenter dan.carpenter at oracle.com
Tue Oct 29 18:29:43 UTC 2019


The first argument of WARN() is a condition so this will just print the
function name instead of the whole warning message.

Fixes: 7b87ea704fd9 ("dma-buf: heaps: Add heap helpers")
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
---
 drivers/dma-buf/heaps/heap-helpers.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma-buf/heaps/heap-helpers.c b/drivers/dma-buf/heaps/heap-helpers.c
index 750bef4e902d..a31684c0d5b2 100644
--- a/drivers/dma-buf/heaps/heap-helpers.c
+++ b/drivers/dma-buf/heaps/heap-helpers.c
@@ -52,7 +52,7 @@ static void *dma_heap_map_kernel(struct heap_helper_buffer *buffer)
 static void dma_heap_buffer_destroy(struct heap_helper_buffer *buffer)
 {
 	if (buffer->vmap_cnt > 0) {
-		WARN("%s: buffer still mapped in the kernel\n", __func__);
+		WARN(1, "%s: buffer still mapped in the kernel\n", __func__);
 		vunmap(buffer->vaddr);
 	}
 
-- 
2.20.1



More information about the dri-devel mailing list