[PATCH] drm: panel-lvds: Potential Oops in probe error handling
Dan Carpenter
dan.carpenter at oracle.com
Wed Sep 4 10:03:29 UTC 2019
The "lvds->backlight" pointer could be NULl if of_parse_phandle()
returns NULL.
Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver")
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
---
drivers/gpu/drm/panel/panel-lvds.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c
index ad47cc95459e..3b4eb959e994 100644
--- a/drivers/gpu/drm/panel/panel-lvds.c
+++ b/drivers/gpu/drm/panel/panel-lvds.c
@@ -272,7 +272,8 @@ static int panel_lvds_probe(struct platform_device *pdev)
return 0;
error:
- put_device(&lvds->backlight->dev);
+ if (lvds->backlight)
+ put_device(&lvds->backlight->dev);
return ret;
}
--
2.20.1
More information about the dri-devel
mailing list