[PATCH] drm: panel-lvds: Potential Oops in probe error handling

Dan Carpenter dan.carpenter at oracle.com
Wed Sep 4 12:57:04 UTC 2019


On Wed, Sep 04, 2019 at 02:50:57PM +0300, Laurent Pinchart wrote:
> >  error:
> > -	put_device(&lvds->backlight->dev);
> > +	if (lvds->backlight)
> > +		put_device(&lvds->backlight->dev);
> 
> How about simply
> 
> -	put_device(&lvds->backlight->dev);
> +	backlight_put(lvds->backlight);

Yeah.  That's cleaner.  I will resend.

regards,
dan carpenter



More information about the dri-devel mailing list