[PATCH v2] drm: panel-lvds: Potential Oops in probe error handling

[Laurent Pinchart]

Hi Dan,

Thank you for the patch.

On Wed, Sep 04, 2019 at 09:55:07PM +0300, Dan Carpenter wrote:
> The "lvds->backlight" pointer could be NULL in situations were
> of_parse_phandle() returns NULL.  Also it's slightly cleaner to use
> backlight_put() which already has a check for NULL built in.
> 
> Fixes: 7c9dff5bd643 ("drm: panels: Add LVDS panel driver")
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Sam, would you be able to pick this patch ?

> ---
> v2: Use backlight_put().  Thanks, Laurent!
> 
>  drivers/gpu/drm/panel/panel-lvds.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c
> index ad47cc95459e..05e8885db7ed 100644
> --- a/drivers/gpu/drm/panel/panel-lvds.c
> +++ b/drivers/gpu/drm/panel/panel-lvds.c
> @@ -272,7 +272,7 @@ static int panel_lvds_probe(struct platform_device *pdev)
>  	return 0;
>  
>  error:
> -	put_device(&lvds->backlight->dev);
> +	backlight_put(lvds->backlight);
>  	return ret;
>  }
>  

-- 
Regards,

Laurent Pinchart