[PATCH v2 0/3] ast, mgag200: Map console BO while it's being displayed

[Thomas Zimmermann]

Hi

Am 05.09.19 um 09:56 schrieb Daniel Vetter:
> On Thu, Sep 5, 2019 at 9:01 AM Gerd Hoffmann <kraxel at redhat.com> wrote:
>>
>>   Hi,
>>
>>> - imo we should fix this by using the io_mapping stuff, that avoids
>>> the overhead of repeated pat checks for map/unmap.
>>
>> Another idea:  IIRC ttm has a move_notify callback.  So we could simply
>> keep mappings active even when the refcount goes down to zero.  Then do
>> the actual unmap either in the move_notify or in the destroy callback.
> 
> Yeah that should be a really clean solution, and only needs changes in
> the vram helpers. Which is nice, more common code!

But the console's BO is special wrt to mapping. Putting special code for
 console handling into vram helpers doesn't seem right. I think it's
preferable to keep the special cases located in fbdev emulation. Or even
better in DRM client code, so that other, future, internal clients
automatically do the right thing.

Best regards
Thomas

> -Daniel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20190905/221f9e0f/attachment.sig>