[PATCH] drm/panfrost: Fix regulator_get_optional() misuse

Rob Herring robh at kernel.org
Thu Sep 5 08:21:24 UTC 2019


On Wed, Sep 4, 2019 at 1:30 PM Mark Brown <broonie at kernel.org> wrote:
> The panfrost driver requests a supply using regulator_get_optional()
> but both the name of the supply and the usage pattern suggest that it is
> being used for the main power for the device and is not at all optional
> for the device for function, there is no meaningful handling for absent
> supplies.  Such regulators should use the vanilla regulator_get()
> interface, it will ensure that even if a supply is not described in the
> system integration one will be provided in software.

I guess commits e21dd290881b ("drm/panfrost: Enable devfreq to work
without regulator") and c90f30812a79 ("drm/panfrost: Add missing check
for pfdev->regulator")
in -next should be reverted or partially reverted?


More information about the dri-devel mailing list