[v2] drm/amdgpu: Remove two redundant null pointer checks

Markus Elfring Markus.Elfring at web.de
Thu Sep 5 08:23:32 UTC 2019


> The functions "debugfs_remove" and "kfree" tolerate the passing
> of null pointers. Hence it is unnecessary to check such arguments
> around the calls. Thus remove the extra condition check at two places.

Will a tag like “Generated-by: scripts/coccinelle/free/ifnullfree.cocci” be relevant here?

How do you think about to compare this change approach with another patch variant?

drm/amdgpu: Delete an unnecessary check before two function calls
https://lkml.org/lkml/2019/9/4/401
https://lore.kernel.org/patchwork/patch/1123689/
https://lore.kernel.org/r/a3739125-5fa8-cadb-d2b8-8a9f12e9bacd@web.de/

Regards,
Markus


More information about the dri-devel mailing list