[PATCH v3] drm: rcar-du: kms: Expand comment in vsps parsing routine
laurent.pinchart at ideasonboard.com
Fri Sep 6 14:33:12 UTC 2019
On Fri, Sep 06, 2019 at 03:50:12PM +0200, Jacopo Mondi wrote:
> Expand comment in the 'vsps' parsing routine to specify the LIF
> channel index defaults to 0 in case the second cell of the property
> is not specified to remain compatible with older DT bindings.
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo+renesas at jmondi.org>
> This trivial change is a leftover from a series that Geert already
> took in. Re-sending as I forgot to add the dri list.
> Laurent, could you pick this one please?
Done, thank you.
> drivers/gpu/drm/rcar-du/rcar_du_kms.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> index fc30fff0eb8d..cb636637032d 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> @@ -625,7 +625,11 @@ static int rcar_du_vsps_init(struct rcar_du_device *rcdu)
> vsps[j].crtcs_mask |= BIT(i);
> - /* Store the VSP pointer and pipe index in the CRTC. */
> + /*
> + * Store the VSP pointer and pipe index in the CRTC. If the
> + * second cell of the 'vsps' specifier isn't present, default
> + * to 0 to remain compatible with older DT bindings.
> + */
> rcdu->crtcs[i].vsp = &rcdu->vsps[j];
> rcdu->crtcs[i].vsp_pipe = cells >= 1 ? args.args : 0;
More information about the dri-devel