[PATCH] drm/radeon: Bail earlier when radeon.cik_/si_support=0 is passed

Hans de Goede hdegoede at redhat.com
Tue Sep 10 09:36:10 UTC 2019


On 9/10/19 9:50 AM, Michel Dänzer wrote:
> On 2019-09-07 10:32 p.m., Hans de Goede wrote:
>> Bail from the pci_driver probe function instead of from the drm_driver
>> load function.
>> This avoid /dev/dri/card0 temporarily getting registered and then
>> unregistered again, sending unwanted add / remove udev events to
>> userspace.
>> Specifically this avoids triggering the (userspace) bug fixed by this
>> plymouth merge-request:
>> https://gitlab.freedesktop.org/plymouth/plymouth/merge_requests/59
>> Note that despite that being an userspace bug, not sending unnecessary
>> udev events is a good idea in general.
>> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1490490
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> Reviewed-by: Michel Dänzer <mdaenzer at redhat.com>

Thank you for the review. I've drm push rights, but I guess that radeon/amd
GPU patches are collected by someone @AMD, so I do not need to / should not
push this myself, right?

> amdgpu should be changed correspondingly as well.

Good point. I'm currently travelling (@plumbers) I can do this when I'm back home,
but feel free to beat me to it (if you do please Cc me to avoid double work).



More information about the dri-devel mailing list