[PATCH v2 2/2] drm/bridge: add it6505 driver

Guenter Roeck linux at roeck-us.net
Thu Sep 12 21:05:27 UTC 2019


Hi,

On Tue, Sep 03, 2019 at 06:51:54PM +0800, allen wrote:
> From: Allen Chen <allen.chen at ite.com.tw>
> 
> This adds support for the iTE IT6505.
> This device can convert DPI signal to DP output.
> 
> Signed-off-by: Jitao Shi <jitao.shi at mediatek.com>
> Signed-off-by: Yilun Lin <yllin at google.com>
> Signed-off-by: Allen Chen <allen.chen at ite.com.tw>

I tried to provide feedback on this patch, but it is far from compiling
against the upstream kernel (or -next), and it has a number of obvious
problems such as missing include files, variable type mismatches, and
set but unused variables. It does compile against v4.19.y, but even there
it generates a number of build warnings.

I would suggest to fix those problems and to make sure that the driver
builds without warnings on top of the mainline kernel before resubmitting.

Thanks,
Guenter


More information about the dri-devel mailing list