[RFC PATCH 3/7] drm/ttm: TTM fault handler helpers

[Thomas Hellström (VMware)]

On 9/13/19 3:40 PM, Hillf Danton wrote:
> On Fri, 13 Sep 2019 11:32:09 +0200
>>   	err = ttm_mem_io_lock(man, true);
>> -	if (unlikely(err != 0)) {
>> -		ret = VM_FAULT_NOPAGE;
>> -		goto out_unlock;
>> -	}
>> +	if (unlikely(err != 0))
>> +		return VM_FAULT_NOPAGE;
>>   	err = ttm_mem_io_reserve_vm(bo);
>> -	if (unlikely(err != 0)) {
>> -		ret = VM_FAULT_SIGBUS;
>> -		goto out_io_unlock;
>> -	}
>> +	if (unlikely(err != 0))
>> +		return VM_FAULT_SIGBUS;
>>
> Hehe, no hurry.

Could you be a bit more specific?

Thanks,

Thomas



>
>> @@ -295,8 +307,28 @@ static vm_fault_t ttm_bo_vm_fault(struct vm_fault *vmf)
>>   	ret = VM_FAULT_NOPAGE;
>>   out_io_unlock:
>>   	ttm_mem_io_unlock(man);
>> -out_unlock:
>> +	return ret;
>> +}
>> +EXPORT_SYMBOL(ttm_bo_vm_fault_reserved);