[PATCH] drm/radeon: Bail earlier when radeon.cik_/si_support=0 is passed

[Alex Deucher]

On Wed, Sep 11, 2019 at 11:29 AM Deucher, Alexander
<Alexander.Deucher at amd.com> wrote:
>
> > -----Original Message-----
> > From: Hans de Goede <hdegoede at redhat.com>
> > Sent: Tuesday, September 10, 2019 5:36 AM
> > To: Michel Dänzer <michel at daenzer.net>; Deucher, Alexander
> > <Alexander.Deucher at amd.com>; Koenig, Christian
> > <Christian.Koenig at amd.com>; Zhou, David(ChunMing)
> > <David1.Zhou at amd.com>
> > Cc: David Airlie <airlied at linux.ie>; dri-devel at lists.freedesktop.org; amd-
> > gfx at lists.freedesktop.org; Daniel Vetter <daniel at ffwll.ch>
> > Subject: Re: [PATCH] drm/radeon: Bail earlier when
> > radeon.cik_/si_support=0 is passed
> >
> > Hi,
> >
> > On 9/10/19 9:50 AM, Michel Dänzer wrote:
> > > On 2019-09-07 10:32 p.m., Hans de Goede wrote:
> > >> Bail from the pci_driver probe function instead of from the
> > >> drm_driver load function.
> > >>
> > >> This avoid /dev/dri/card0 temporarily getting registered and then
> > >> unregistered again, sending unwanted add / remove udev events to
> > >> userspace.
> > >>
> > >> Specifically this avoids triggering the (userspace) bug fixed by this
> > >> plymouth merge-request:
> > >> https://gitlab.freedesktop.org/plymouth/plymouth/merge_requests/59
> > >>
> > >> Note that despite that being an userspace bug, not sending
> > >> unnecessary udev events is a good idea in general.
> > >>
> > >> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1490490
> > >> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> > >
> > > Reviewed-by: Michel Dänzer <mdaenzer at redhat.com>
> >
> > Thank you for the review. I've drm push rights, but I guess that radeon/amd
> > GPU patches are collected by someone @AMD, so I do not need to / should
> > not push this myself, right?
>
> I'll pick this up later this week when I get home from travel.

Applied.  Thanks!

Alex

>
> Thanks!
>
> Alex
>
> >
> > > amdgpu should be changed correspondingly as well.
> >
> > Good point. I'm currently travelling (@plumbers) I can do this when I'm back
> > home, but feel free to beat me to it (if you do please Cc me to avoid double
> > work).
> >
> > Regards,
> >
> > Hans
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel