[PATCH 0/2] drm/nouveau: Two more fixes
thierry.reding at gmail.com
Mon Sep 16 14:36:04 UTC 2019
From: Thierry Reding <treding at nvidia.com>
I messed up the ordering of patches in my tree a bit, so these two fixes
got separated from the others. I don't consider these particularily
urgent because the crash that the first one fixes only happens on gp10b
which we don't enable by default yet and the second patch fixes a crash
that only happens on module unload (or driver unbind, more accurately),
which isn't a terribly common thing to do.
I'll be sending out fixes shortly to make the GP10B work more properly
on a wider range of Jetson TX2 devices and enable it by default.
One thing to mention is that I'm not exactly sure if the first patch is
the right thing to do. I haven't seen any issues after that change, but
I'm also not exactly sure I understand what BAR2 is used for, so I don't
know if I would've even covered those code paths (other than the one
causing the crash at probe time) in my tests.
It'd be great to get Lyude's feedback on the second patch, since that
call to pci_disable_device() was rather oddly placed and I'm not sure if
that was essential for things to work or whether the slightly different
point in time where it's called after this patch is also okay. It looks
to me like it should work fine, but I don't currently have a way to test
this on desktop GPUs.
Thierry Reding (2):
drm/nouveau: tegra: Fix NULL pointer dereference
drm/nouveau: tegra: Do not try to disable PCI device
drivers/gpu/drm/nouveau/nouveau_drm.c | 3 +-
.../drm/nouveau/nvkm/subdev/instmem/gk20a.c | 30 +++++++++++++++++++
2 files changed, 31 insertions(+), 2 deletions(-)
More information about the dri-devel