[PATCH] drm/bridge/synopsys: dsi: Use devm_platform_ioremap_resource() in __dw_mipi_dsi_probe()

Yannick FERTRE yannick.fertre at st.com
Mon Sep 23 09:05:19 UTC 2019


Reviewed-by: Yannick Fertré <yannick.fertre at st.com><mailto:yannick.fertre at st.com>
Tested-by: Yannick Fertré <yannick.fertre at st.com><mailto:yannick.fertre at st.com>


Best regards

--
Yannick Fertré | TINA: 166 7152 | Tel: +33 244027152 | Mobile: +33 620600270
Microcontrollers and Digital ICs Group | Microcontrolleurs Division


On 9/21/19 8:20 PM, Markus Elfring wrote:

From: Markus Elfring <elfring at users.sourceforge.net><mailto:elfring at users.sourceforge.net>
Date: Sat, 21 Sep 2019 20:04:08 +0200

Simplify this function implementation by using a known wrapper function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring at users.sourceforge.net><mailto:elfring at users.sourceforge.net>
---
 drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
index 675442bfc1bd..6ada149af9ef 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
@@ -981,7 +981,6 @@ __dw_mipi_dsi_probe(struct platform_device *pdev,
        struct device *dev = &pdev->dev;
        struct reset_control *apb_rst;
        struct dw_mipi_dsi *dsi;
-       struct resource *res;
        int ret;

        dsi = devm_kzalloc(dev, sizeof(*dsi), GFP_KERNEL);
@@ -997,11 +996,7 @@ __dw_mipi_dsi_probe(struct platform_device *pdev,
        }

        if (!plat_data->base) {
-               res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-               if (!res)
-                       return ERR_PTR(-ENODEV);
-
-               dsi->base = devm_ioremap_resource(dev, res);
+               dsi->base = devm_platform_ioremap_resource(pdev, 0);
                if (IS_ERR(dsi->base))
                        return ERR_PTR(-ENODEV);

--
2.23.0



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20190923/1c20ad67/attachment.html>


More information about the dri-devel mailing list